From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
Narcisa.Vasile@microsoft.com, talshn@nvidia.com
Subject: Re: [dpdk-dev] [PATCH] eal: create a runtime directory on windows
Date: Mon, 26 Oct 2020 12:01:47 -0700 [thread overview]
Message-ID: <6bf4b9f3-68c5-7546-4d43-e5361a577835@intel.com> (raw)
In-Reply-To: <20201022220518.3ddab665@sovereign>
Hi Dmitry,
On 10/22/2020 12:05 PM, Dmitry Kozlyuk wrote:
>> /* Detect if we are a primary or a secondary process */
>> enum rte_proc_type_t
>> eal_proc_type_detect(void)
>> @@ -181,6 +231,13 @@ eal_parse_args(int argc, char **argv)
>> }
>> }
>>
>> + /* create runtime data directory */
>> + if (internal_conf->no_shconf == 0 &&
>> + eal_create_runtime_dir() < 0) {
>> + RTE_LOG(ERR, EAL, "Cannot create runtime directory\n");
>> + return -1;
>> + }
>> +
>> if (eal_adjust_config(internal_conf) != 0)
>> return -1;
> Windows rte_eal_init() forces in-memory operation (internal_conf.in_memory=0)
> with a warning message, because runtime directory and shared configuration is
> only used for multi-process. Maybe do the same for no_shconf, as it's
> essentially the same, but for legacy mode?
Thank you for the suggestion.
We sent out v2, forcing no_shconf to 1 for now.
next prev parent reply other threads:[~2020-10-26 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 20:26 Pallavi Kadam
2020-10-22 18:15 ` Ranjit Menon
2020-10-22 19:05 ` Dmitry Kozlyuk
2020-10-26 19:01 ` Kadam, Pallavi [this message]
2020-10-26 18:44 ` [dpdk-dev] [PATCH v2] eal: enable windows apps to run on non-admin users Pallavi Kadam
2020-10-27 23:10 ` Dmitry Kozlyuk
2020-10-28 12:41 ` Burakov, Anatoly
2020-11-03 20:28 ` Thomas Monjalon
2020-10-29 18:37 ` Narcisa Ana Maria Vasile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf4b9f3-68c5-7546-4d43-e5361a577835@intel.com \
--to=pallavi.kadam@intel.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).