From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) by dpdk.org (Postfix) with ESMTP id 243E61B270; Tue, 10 Oct 2017 13:47:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1362; q=dns/txt; s=iport; t=1507636071; x=1508845671; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=QGy+Du/sDccVNN4aAf+lpuIMSV1FBCj/klT8CS5wnQw=; b=LmxqseCth9eGCh5uHNbhKCU08QhwUXOvhElVIjOTd/SifUzq9nhlPcWA 6wCRA5Q9Od7VjMKeYEIwSJ2qrQkIpR/P8vSpy/HRmvqaWoQnsvBQIY/3P 3fVvUte9IkA1wX2Qty+LOUpQl+efK0zkxvKOOvPtFtuXJ1/ICk7e7ljbR 8=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CcAQBWstxZ/4MNJK1cGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1tkbieDepoTgXaWL4ISCiOFGAKESUEWAQIBAQEBAQEBayiFHgE?= =?us-ascii?q?FIw8BBUEQCxgCAiYCAlcGDQYCAQEXigkQqASCJ4sjAQEBAQEBBAEBAQEBASKBD?= =?us-ascii?q?oIfggKBUYFqK4FwgQ6IF4JhBaE8AodcjQuCFFyFF4Nahy6VYYE5Jg0kgQ54FYg?= =?us-ascii?q?CJDYBij8BAQE?= X-IronPort-AV: E=Sophos;i="5.42,504,1500940800"; d="scan'208";a="305859714" Received: from alln-core-1.cisco.com ([173.36.13.131]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Oct 2017 11:47:49 +0000 Received: from [10.150.214.100] ([10.150.214.100]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id v9ABln8m020314; Tue, 10 Oct 2017 11:47:49 GMT To: Bruce Richardson Cc: Qi Zhang , konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org, stable@dpdk.org References: <20171010132205.72173-1-qi.z.zhang@intel.com> <20171010084807.GA34984@bricha3-MOBL3.ger.corp.intel.com> <20171010113959.GA40296@bricha3-MOBL3.ger.corp.intel.com> From: "Roger B. Melton" Message-ID: <6c3a1cbd-e28a-a9cc-ed46-e08dc03644ce@cisco.com> Date: Tue, 10 Oct 2017 07:47:38 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171010113959.GA40296@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 11:47:51 -0000 On 10/10/17 7:39 AM, Bruce Richardson wrote: > On Tue, Oct 10, 2017 at 07:05:33AM -0400, Roger B. Melton wrote: >> Hi Bruce, >> >> I can.  It will take a day or 2 to get the results. >> >> Regards, >> Roger >> > Thanks. Keep us posted. We want to ensure we have the best fix possible > for the issue in this release. Thanks for finding a better solution ;-).  I'll let you know the results when I have them, just wanted you to know it may take a couple of days to turn around. -Roger > > /Bruce > >> On 10/10/17 4:48 AM, Bruce Richardson wrote: >>> +Roger Melton >>> >>> On Tue, Oct 10, 2017 at 09:22:05AM -0400, Qi Zhang wrote: >>>> vPMD tx does not set sw_ring's mbuf to NULL after free it. >>>> So to prevent same mbuf be free again, we need more carefully >>>> check in i40e_tx_queue_release_mbufs. >>>> >>>> Fixes: b4669bb95038 ("i40e: add vector Tx") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Qi Zhang >>>> --- >>>> v2: >>>> - fix at i40e_tx_queue_release_mbufs so no performance impact. >>>> >>> This patch also supercedes this one, http://dpdk.org/dev/patchwork/patch/29814/ >>> right? >>> Roger, can you please confirm that this alternative fix works in your >>> testing and that your patch is no longer necessary too. >>> >>> Thanks, >>> /Bruce >>> >>> . >>> > . >