From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD8AD42393; Tue, 10 Jan 2023 17:51:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6F2240A8B; Tue, 10 Jan 2023 17:51:27 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51]) by mails.dpdk.org (Postfix) with ESMTP id BB6AC40687 for ; Tue, 10 Jan 2023 17:51:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NuHOLmrjIHiWtnCctWSG+3YCjXlgdvESh/nG6rJZoWVqOUJOrPLloFb6npAxrWVaZ6ngV8ZjnacdOqWfuOVxp49eim19AXC+iHDnvJ2vux+XAsh8mln++vsaV4oa/1/7an6NVsqywqwhuvvXKDXKaJRKZU76Ymtm3cN8QyN3D2GKgvyXjW/8MG4HDxfjUonk5tDrUwPohEOkAWumRBZxw1jpTSml6LZfED/GTP26yDurbyHMfa+W4kG4LD46pmZXUDoVwUNJIFpXrgbD5ggKnqgpfX3laA4B1YwsJsNWw+oG2aLY4WClG0sRLbMQi1quFNG5bP2mxfNAj6NPgqAtVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=St91bJDHp2L0/rnZoOann7MK6scyOF+zGl8PvaZIgOQ=; b=SCpV9x3X+Ac1AbS2zvcAGOce/enDFNrgaeppJnLpMSOzM1AWyfsakkRNqKroDk/bYyBseBcHUeYuT0Q1qDKARlmTzw0VkwLxooKAYhdz9DICei8oqNl91nnwfhCSjv06qrGAYBSGpssq2ewXZsEC23jH+0bvP0Trb9zusf8oNx3WAZd1FJOj7q+xkm+2b4lJ8LjB9eHANeE/5+aLdHnojq4fpG9mKYHoaPsdhq9BBP+1Yb7kTlMqssPnnhf0d1U7XMrZUbWLymS9aelyR4hXOEU6CFl6jEIMM6fUrJmSDY/d0+cSQ1/K7y7JdvPkojUFdZboY2ftCmEHp4GLxg8Ugg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=St91bJDHp2L0/rnZoOann7MK6scyOF+zGl8PvaZIgOQ=; b=AvU5sxilLiBpmPtriugjtvar4w/ePFsVM38O+Xmn7+6V4j0ePrh5BfbmjQEzO4wo9VWXqtm453Qya9jVll2uQgvqxdKOUx8qABYyg05TSMA6e9QRoTCklObobE24r1CJeOY/jM3BJEQo1wMszP+70vkRajpgH/MLahGv+N9MPco= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB8012.namprd12.prod.outlook.com (2603:10b6:a03:4c7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 16:51:24 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%9]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 16:51:24 +0000 Message-ID: <6c448463-b3f0-d128-b144-d4e93c5c11d7@amd.com> Date: Tue, 10 Jan 2023 16:51:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port Content-Language: en-US To: Huisong Li , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru Cc: thomas@monjalon.net, liudongdong3@huawei.com, huangdaode@huawei.com, fengchengwen@huawei.com References: <20220825024425.10534-1-lihuisong@huawei.com> <20221206092649.8287-1-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: <20221206092649.8287-1-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0271.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37a::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB8012:EE_ X-MS-Office365-Filtering-Correlation-Id: b48be858-18ae-4742-dfa3-08daf32ae841 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D3f8CRqNVRALuqw6rTXfEX+Is3UpHRjJ3ZgSX1Ilpx3KPsy6lAaSn8pZJ55+uMpKV7M888aDDR0NLJTMccW589FN/Ea4jLR5b1+/bhx57y/aOtViwq5LXnYe80fFf6sjCUmD5mn12ryBmLHQqp0EQMbdnhKsUMCAMiAGhvXJCmOPVwOtRNIhY+L9r8PyhVnggO6cJPdKet+kld4SB4Xl8th6ILWYI9q/XBIMmI5WBztuJzUFSAZiBypCAagtWkH8MTI/a9TxZF7ECT0++JYSS3Pl4wY/h4ob2re/l128cN3WeDU734/xyxga+9tFOi38dEs99C6WWXYBztAtTJj838V6nuSKtcCNvYz3SmcOvTl6zw9UjMiHpl9AJxxIB4iZM1OdBvWv/l9P6/oUJYLTDfdF0Vvjoh0wzfwZ7pWewHcg+juhwTa7egUZuJl6mqJpKtLqFwrd5IUPOAtOWN0EjDj8z4z80MSb+gInGZgGyY0opPK0QkXZXPvmrWwoK6BS6psWwMVZqfazFI27mMoIa4ZS72D1n0ePW20PzDrhAAs9yMDk4dbrqRPfeZbGtqJBv4fx554nuZ6JmD9XrpND3vHxEFE749ZCGZ5DgJMSmKtYZRd8WKqJ5N4Nz1ack+TyNcXAuexKNOLDkdpZAhwiG+uyMknKp74kgh2+Wmfs3JK1qjTiM53rtEnQ31n1cnTG8RRfgbT3Fto3riWjSoeEpFy2M8PuOawfkIhRXVD6wmg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(451199015)(316002)(5660300002)(26005)(6512007)(186003)(44832011)(6486002)(478600001)(2616005)(31696002)(41300700001)(66946007)(4326008)(66556008)(66476007)(8676002)(8936002)(83380400001)(86362001)(36756003)(6666004)(53546011)(31686004)(6506007)(38100700002)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHovZ3Y5NnV4c0Q5K2piYjBqSGd3ODJGeXA1eUI1SGw1eEpNbnduU1kvZGpR?= =?utf-8?B?cVFiaGdKeGxxS01ESWpmR3A1RFNuc1puQnNqRXU1WStES29jaCtKWG5iNWh3?= =?utf-8?B?MW92TmxMWFczUjZhbUxFUXNzSWI4a3hqMDQyeFh0bGszbWxBcnc2d0tseW81?= =?utf-8?B?K0QrWWplS1NhaVRGWTd2TnZGdk9KU240N1daMnJDK09DbHBvZEJvcFNzVGgy?= =?utf-8?B?cEdWWGFYM1V2ZDNobU9WZ0szWGt4Mm1jekE2R1VUeG4ra2hCS2hSNEpRVTMr?= =?utf-8?B?ZWlKeWhyUytEK25DYWxiK3NXRHUzSFBkKzNpYzRKVFBjenRMUHYrM3p1anVW?= =?utf-8?B?RDErUWxBbTJrU0ZnSTltVWZHWVlzamlpaGk0SW54OFN2Nmt0MEptNVhjWitV?= =?utf-8?B?alpSV0pzazBhY0tJNlgzS08vSzY1eVFmTFVvR2ZERHlsNXRHM25ZT2VqdkY5?= =?utf-8?B?MkR5VU51YllCLzllTDJ3eXkwdms2NWx6QVNqOGpiNzZ0NUoyTXlPcXBIOVk3?= =?utf-8?B?VHp3MU55eHhTMXM4ZGp0aEdjc2VvQjIzdXIrSE1SLzRQRHVLaytkNklXMm8v?= =?utf-8?B?SnhHU0VaRDBrNFMvTmMxdnIrTkxDd0Q0QkhCZ0dDVm5wbFN1bGZhNTRwN09G?= =?utf-8?B?VGRsenM1d3NnSFNQVURzakhJQmI0Nm8yUi84aWdwQkdIOVBHM2ZaZ3NxZVE3?= =?utf-8?B?RjY2dnVRaFpvcnhMMTllUlJESWFMSGw4bTErbEZ4VGY4ZUdScGp5M3h3QzdD?= =?utf-8?B?T3phWmlqVlFaOGJmVnl3bmwrNTNDV1JVTWFyZkt2d1pQMlNVTGxGYk13eDFC?= =?utf-8?B?c1pYczFuYlgvVDJRS2Z6Z3gwUi9sYXVNcDNla1U3SlR3cUE2bHpCYlI5aXBH?= =?utf-8?B?TVMxTW5HNDI4MXRzWmtWV1FFQXJ5Q0orQXFYektWekYzbXBDWVJxYUs4a1JV?= =?utf-8?B?anNzWHIwU053M2xNTThQY2lSRWUxckdvcEF1czhSYzJaRWtzWG96Mmw4OHFS?= =?utf-8?B?UXp1aUJsWmlMQlJpL3A5Q1RMbVJmaG5vK05tYlpVQi9RQWVhR2FQdkhobS9L?= =?utf-8?B?akc5czl5dnRtNG12U0JocDY4blFMVnRKaytheTJ2SGc3djlCUWl4a3B6RkQr?= =?utf-8?B?eXU4ZjI1UWJtMkpLbGFVM1VsUjhHbjh5YVBKYXBHR2htblUxcjd3UG8yak1x?= =?utf-8?B?cjQzTjFGR0t4MXRTZ211NEZ3NGx5ZnIvd3kxUVRBeFRWSmJIeUtqbFJpTksz?= =?utf-8?B?WGcxakxCNG9GT3FBQklTRTUrcEg5ZldpZzRRSDV6WFFvU3VlYm85cFBrdmVW?= =?utf-8?B?QmhndVoydTI1V0kwM2l3Ri9SaytaMU8zTTRGWnR3VVcxRE8zcXdYTUVmN0FI?= =?utf-8?B?dmdBcVNZOTI2RXgrUVBCNEhvSHZDVTAwbHNxVThNaUorbnFsTEZteS9ZelBx?= =?utf-8?B?QUljWW1CbkRwekZXNXFZWUJ1aXA0dVZLWWRsREs5QmRFL3ZmbVkrT3JhVmtO?= =?utf-8?B?RWJzRDEyeVNnTDZ3MzRtc3owdm1uNWpNSldwTTI0V0twa1E5akdvZCs3ejJr?= =?utf-8?B?elNWS1JYMlRQNEl3UG5YL2ovRU9JOUtSQTI5cXJLaHZmQUk3c0tqMkpUQjZU?= =?utf-8?B?eUZFbGQraVdXT2U5QXRjRXZVTEVIQUFXZXVVdnpqQlZvWU5ibXBMNmNER2JK?= =?utf-8?B?V3NEL09ackRmTWVjK09tbkx4WVJhbHBnOU9xWWE3Q2k0eFBEWWJ2eHJEWDkx?= =?utf-8?B?SEdNTTZRQWk1SnptMGtKNk1CVDZudzNkL3laTXl3dGJnZzN2SmVwUUhYcHZk?= =?utf-8?B?V21lRWZBeWdKNlovTDFlZ0VwS3hRK1ZrUExCQ2NyRVNIUGhvN3FGTE44dlha?= =?utf-8?B?b2RNMXV1dnJERmJXb05uczdnUERhZE9MaDdXekxLR2Zid09jdmpMZko2OFdV?= =?utf-8?B?NHpENE1sUVBSeHFsK2QyUnVPTU1XQWR3OVc1MWlFWlI4VytacElyTUpCTTdM?= =?utf-8?B?Y3J3eW5jUXJvWUFIUFMyZ2VHYjRIdWZ5cExEaFdCWU5haUVSdVFiMVdwWG1M?= =?utf-8?B?VEh5M1pYT0wxUHlrZVlubjBTN2J0WnlwUHZNQnNYa1lzZGNrMERNNXB1Rk9K?= =?utf-8?Q?tOXSbE2nqRT2D1I+Po8iU04XK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b48be858-18ae-4742-dfa3-08daf32ae841 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 16:51:24.0121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hdKKEyaUvCRlj+ibKu8HlLb5PKUpY4cxdaMKcDd5GCU8EpcKdnvglmWT4jinrX2y X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8012 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/6/2022 9:26 AM, Huisong Li wrote: > This patchset fix some bugs and support attaching and detaching port > in primary and secondary. > > --- > -v4: fix a misspelling. > -v3: > 1) merge patch 1/6 and patch 2/6 into patch 1/5, and add modification > for other bus type. > 2) add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve > the probelm in patch 2/5. > -v2: resend due to CI unexplained failure. > > Huisong Li (5): > drivers/bus: restore driver assignment at front of probing > ethdev: fix skip valid port in probing callback > app/testpmd: check the validity of the port > app/testpmd: add attach and detach port for multiple process > app/testpmd: stop forwarding in new or destroy event > Hi Huisong, I haven't checked the patch in detail yet, but I can see it gives some ABI compatibility warnings, is this expected: 1 function with some indirect sub-type change: [C] 'function int dpaa_eth_eventq_attach(const rte_eth_dev*, int, u16, const rte_event_eth_rx_adapter_queue_conf*)' at dpaa_ethdev.c:1149:1 has some indirect sub-type changes: parameter 1 of type 'const rte_eth_dev*' has sub-type changes: in pointed to type 'const rte_eth_dev': in unqualified underlying type 'struct rte_eth_dev' at ethdev_driver.h:50:1: type size hasn't changed 1 data member change: type of 'rte_eth_dev_state state' changed: type size hasn't changed 1 enumerator insertion: 'rte_eth_dev_state::RTE_ETH_DEV_ALLOCATED' value '1' 2 enumerator changes: 'rte_eth_dev_state::RTE_ETH_DEV_ATTACHED' from value '1' to '2' at rte_ethdev.h:2000:1 'rte_eth_dev_state::RTE_ETH_DEV_REMOVED' from value '2' to '3' at rte_ethdev.h:2000:1 1 function with some indirect sub-type change: [C] 'function int rte_pmd_i40e_set_switch_dev(uint16_t, rte_eth_dev*)' at rte_pmd_i40e.c:3266:1 has some indirect sub-type changes: parameter 2 of type 'rte_eth_dev*' has sub-type changes: in pointed to type 'struct rte_eth_dev' at ethdev_driver.h:50:1: type size hasn't changed 1 data member change: type of 'rte_eth_dev_state state' changed: type size hasn't changed 1 enumerator insertion: 'rte_eth_dev_state::RTE_ETH_DEV_ALLOCATED' value '1' 2 enumerator changes: 'rte_eth_dev_state::RTE_ETH_DEV_ATTACHED' from value '1' to '2' at rte_ethdev.h:2000:1 'rte_eth_dev_state::RTE_ETH_DEV_REMOVED' from value '2' to '3' at rte_ethdev.h:2000:1 1 function with some indirect sub-type change: [C] 'function rte_eth_dev* rte_eth_dev_allocate(const char*)' at ethdev_driver.c:72:1 has some indirect sub-type changes: return type changed: in pointed to type 'struct rte_eth_dev' at ethdev_driver.h:50:1: type size hasn't changed 1 data member change: type of 'rte_eth_dev_state state' changed: type size hasn't changed 1 enumerator insertion: 'rte_eth_dev_state::RTE_ETH_DEV_ALLOCATED' value '1' 2 enumerator changes: 'rte_eth_dev_state::RTE_ETH_DEV_ATTACHED' from value '1' to '2' at rte_ethdev.h:2000:1 'rte_eth_dev_state::RTE_ETH_DEV_REMOVED' from value '2' to '3' at rte_ethdev.h:2000:1 ... there are more warnings for same issue ...