From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D14542B19; Tue, 16 May 2023 00:27:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AC5E40A7A; Tue, 16 May 2023 00:27:15 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by mails.dpdk.org (Postfix) with ESMTP id DE22A4068E for ; Tue, 16 May 2023 00:27:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C64a1+iqTURcdnQw2So/cZo8+07czUmWi0rr+8N9pcjrzqPAuJtFA+SY3QWOOeF6jgKSPvlsocr8cHoaQ97ilyvWZDTno3P9pMuwPwzc4bPbefFENtZIctfqr5CO0fuWO3tD01R3+cHLj3R4QG1IXh8KRFRws5xIt74oG0O5eeaRuAkl0Oqv7B4Eby8yvmmfBFCtUc/l95nS/1Q4jXDjy4T5Y+VtjwqJfgByqWw2HgUHksaGF8pDb7zMBdUpUcuh+nduai3gfEOZDESs4yw2/QQ2O5PrHy9MwdJ2wsj+Qgzck+TTFOHPEPW5uFSqGvij8SHJh+lH+o60dr471cPtSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cspm7F53DvQCYJ6gr535MBpCCSuG4bfAdnYDgySuXIY=; b=Ph3felc8qMSWbN0KO4B3qoDkuDjTcMDyJYQ63x/Rd5mnlf+tgwqA3O46f9L4pda0/1Yaq8kd9hS83ewuhk7vrz6UARKl+oCfjBSOjfwPiVtC0P8EofxxKCBQL7uxQcfJH7PbBaciMFyXYvq/XGJtBjkvQNdX/aOqGoOC3WEviadqPNugV5oVBc9cHfCzo71j+tWXgC9z5wFNfk6KiSr3tClzGwyW3y2jyP7S7Prq9vBP2FyiDl8D3I0Pz+/L1Enidm5Smg17xbmE5J4OUBI3PztN4e3z1iFWGEOB7xfgTJjHHPmZM0yV04nD81Ek1SXwisz/eZjLNYHUKPp6/oTa1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cspm7F53DvQCYJ6gr535MBpCCSuG4bfAdnYDgySuXIY=; b=g83znKMRO2cnvlSGeCFcsYhM9Jfir3oCt0YH2jbon3mzSQwOIt7ZmTdqvKtrWX7UTBpvutSt/vb77bsZ41aGwTZFB8e0i/2PG+NwxXaCjt8uwteuC8Zj8nq69c6O1Ppq8cCXjT/9qTPoItJSeCP4DmPtK3HVvqsdjkxqJl9IzUY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7132.namprd12.prod.outlook.com (2603:10b6:806:2a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 22:27:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6387.030; Mon, 15 May 2023 22:27:11 +0000 Message-ID: <6c4b95ca-48f3-d1e2-7b39-c1c251095493@amd.com> Date: Mon, 15 May 2023 23:26:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Joshua Washington , Aman Singh , Yuying Zhang Cc: dev@dpdk.org, Rushil Gupta , Stephen Hemminger References: <20230412181619.496342-1-joshwash@google.com> <20230421232022.342081-1-joshwash@google.com> From: Ferruh Yigit Subject: Re: [PATCH v5] app/testpmd: txonly multiflow port change support In-Reply-To: <20230421232022.342081-1-joshwash@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0404.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7132:EE_ X-MS-Office365-Filtering-Correlation-Id: e14f962d-0c84-448a-f47b-08db5593867c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rhz2BcpSjs/xWSPXaZliTIFHyeJpWY6+vuVXuFXSOxzeOQTIODQlQKD6DEpiN/MO3DeH/4Wpx11h+vVleDVjP98hLzTxCTsWjmqzko70UZ5YMcGVcVJVmRKuuZOTjzJrdj2YgGDYFbAyKPmXb8ZbFJSDuhXVMmRlQM97Dfmad042+21UFxZvmfQQsU0DvNQzgENJDVrGDpusWZSqapJouIUhabvNJvPnUAb4vNgktfyS/vzPNxXHpWH5ui929SJ7z72q92jI+Q8NLp+/UG+g8uPbFwErBH41g6VyK30YflUR1UN3J62oVV5pguHdqurVHZP7Ul8NJ6abTHSLBfYrJMItuuY9vHy8d/BYuMP4Dkq5x7XGpx3Qi/IuGFF3c2+oHE8rATDU8WXOc2krpDU/FhHuDZmoZeJzdUpjwXoCe1nzwDHiPrjlmDt8FEhrfrbk+UcvtmWwgbfd5Ln4WmRHs2p3Eqs0Unrk/ujQBj5TGTQA8tKVJGUjXZ50OTU7HOYHeF9hTPzdPJC2Qq4/BLUynIb1nmRhmh6+HfXatGraxGXcOS3d5hqTtTjXyTgCOxYGt5eWl/I0Q7UeOwQuYsAxf504lp9iZ/nMWu7bu5J2Wr7pXVOb1hh8KlUiuwtuNoULGGO7QSyyfVWJhKRnDv1Cxq1+oe9ldy4jNVsBJY6Z+nc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(396003)(366004)(136003)(39860400002)(451199021)(83380400001)(31686004)(5660300002)(44832011)(8936002)(8676002)(31696002)(86362001)(316002)(2906002)(2616005)(54906003)(186003)(110136005)(6506007)(6512007)(53546011)(478600001)(26005)(38100700002)(66556008)(66476007)(41300700001)(66946007)(4326008)(36756003)(6486002)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXlFZjNTdzZGN2pncEx2K2loUUlXTmdhaHB4NmJHaGpNL1lwUjhuaHBqMlhL?= =?utf-8?B?RDdBNlhUb3RnMnNiZEM0dFVGcE5KK3ArdkdvQStLSjdRSFZ3VGlLeEd6ZUdU?= =?utf-8?B?QkQ5dlY2T1N4TE1oc1lJL25JalhDMTBEaFV4UGFScVdkb0c4S0htZlFpSDVO?= =?utf-8?B?K2hCLzJqQnBiNGNXR0dzcjBEMEl6bXdLSGlybnkzM2FWUHBaN0ZneTZZQnZY?= =?utf-8?B?Sk10UXMzWStMQVhSZ3EvcThWeFdXYVkwS2FzaTZtdTlzcUZkQXNpNVkxQkd1?= =?utf-8?B?WHZjTlZZbFg5ZFRiSWJKTG1SYzdsUjNjWjhUM3Q2cXJUUlZzQ3drbzR5azNo?= =?utf-8?B?UlI0VmcrNjZaWklueGo5WVQzbTVhbXEyZkxlTDNZSG5aOGk5Wk9EWGpmelIz?= =?utf-8?B?UmJWUVBjalNnZ09DRkN6R1JIclYvdE8xN3gxUS9rRDBIcW5DeVBleDh0VTZa?= =?utf-8?B?VHJnMG0zS1I5Z1pVd01Cd2lRNldIeUtjenp2Ulg2SlRZS3RCQTQ2SktQMzVQ?= =?utf-8?B?UXo2cGNydmpkQ3R3dTdBR2dxcjY3aTlzeTcyYlV6R2wrS0g4SUd5N2VEMXBr?= =?utf-8?B?SHJFYy9WckMxM0ZHaXlGODdVZW9pSnJoaFB1ZFBJTHVRL0FNV05Oa1JDR2I0?= =?utf-8?B?Z3BqYkg2QjZHdkFPeVdIUHJRSnZxVkExVi94WnpZZ0FUVTZyMG56a0pvU0Fj?= =?utf-8?B?cURCTTVIaXdLOVZIR01jOGhoQ2psNHRJdTVJaTB6ZXl6WnRzVEkrayt1K1Zz?= =?utf-8?B?cFl0UUZxT0xsb25NbEt5ZVlSTC8rdVZITkZrWTFQT09wUXppN3VmVXg2Ymxi?= =?utf-8?B?RUN0MS81ak5oTCtiL3k5Z25RenVWQzRnbzZiL21DR29PUkp0NHFKVXBkZ01O?= =?utf-8?B?MnNsdlExVVBUNTZCdXorcTVhK3EySnMvUWNtNFVyMnRPeUNXendsN1d4MWFI?= =?utf-8?B?ZTNzMXNncjR4QWdvZVczWUZCbXJQRHhmaGFudWpqcmtseXYrNFN4MHNqM0Nt?= =?utf-8?B?QmtUc3Y0WjB1Ny9PYkZYTXBLMTJlRmt1dXlsNytMVHVRWG5uaENwaER5QmVN?= =?utf-8?B?Q04wNVBlS1dNSkhNNUFGSzBQbWk5YnM5eE8wempXbC9oSTRuZHV6TDRJR0xJ?= =?utf-8?B?N1pleE4vVGVWS21OMnBnOTREdzJza2tCMDRqVHFKUWNWTmJ4czhjcUt5VDhv?= =?utf-8?B?ci8rRTQxdGl1Z0xlMjBWN2s3UXV0aXNkZEpFbDhDQmlwUFJ3Q1pON1NpbWdU?= =?utf-8?B?WERiaGdZdE9iQTF4SFNMUTVnb3R1VHdBcUhnb0xsZGlRNWxkalpZRzRRc2ln?= =?utf-8?B?REhkdnU0VW15SzFPaW11WDU4QWkrZGk2Vll4QXFCL2t1UjJ4TFFtWU5hTWs2?= =?utf-8?B?Y2RoVmNNNkZncUtUQldKMS9NaGZUMkxROWYyTmJkcGtFVUJRMzZzc1g0SUZj?= =?utf-8?B?RGFRcVNtMXRkTkxwdmp4VkVKYVBQVVdROHVTcFIzMDhkSjA3NmFMK25ZbWNW?= =?utf-8?B?M1VyM0pZbXRGRXV6V2FuYUJWYXdaS1N0OHZLMHZ5bWY5Z0FuQnYvSnhPUExJ?= =?utf-8?B?a2Ntd0o4bG8xY1hEWDlZTWs0Z1NxcCtleldmdUNOZHdvb3dSVW1Md05oZVcr?= =?utf-8?B?UzJWWS9FZmh2K2hhbU9zVVdNM0ttWVhERDcvSmR2M0VxYlpKZk9kbEpza2pq?= =?utf-8?B?ZWZUQU1tSVBacFFIRTNwZVNmeUEzNlNtdERiblhxcVU5eXFQVkowWnFEdkk4?= =?utf-8?B?cmN4RjZiWFBUeFI5NFFsck8zQWlkeGdXNEZrNzRwdDVFTFJCTXRNRmhMYVVC?= =?utf-8?B?bUpJMnhCWUI4Nldxc0dXNXljM0E3aDdQdjRJWDg5R1RDWGszRmNHK1BnL3pt?= =?utf-8?B?R2ladU11bUtFNnlCNXZZa2I4cWZkNjlubVhQdEFjV1prSkgvUUVNSHhsZUlD?= =?utf-8?B?TmtaWDU2NFhDRXczRE9LOGIyeE05NlhEWUtrN0RLZXp3UzFPWmU2M050WUFq?= =?utf-8?B?Y2t4NnNFUUQ1ZVBueDlUNGZJOU1iZkJQS0x4Y0dTNzU3M21iTmdxMVRJSWc2?= =?utf-8?B?aUkrQUw1cWlrWWhvbnVucjBQUEVzWnVYbGlUMTBla0JZMkRBN2pvWXUwajYx?= =?utf-8?Q?a3NHAxiW7r1cjKIl9SOEWP6xy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e14f962d-0c84-448a-f47b-08db5593867c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 22:27:11.4112 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AKy/BdRuv5F7mzK6xlda5ybkQLe2rxdxEKW1RtS9iGqwRLgIHf6uyJY5POK+WPPo X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7132 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/22/2023 12:20 AM, Joshua Washington wrote: > Google cloud routes traffic using IP addresses without the support of MAC > addresses, so changing source IP address for txonly-multi-flow can have > negative performance implications for net/gve when using testpmd. This > patch updates txonly multiflow mode to modify source ports instead of > source IP addresses. > > The change can be tested with the following command: > dpdk-testpmd -- --forward-mode=txonly --txonly-multi-flow \ > --tx-ip=, > > Signed-off-by: Joshua Washington > Reviewed-by: Rushil Gupta Hi Joshua, Aman, The reason to support multi-flow in Tx-only mode is, to test RSS in the Rx side. When used in guest, in a hypervisor infrastructure what is the usecase for multi-flow, why not use default single IP? And if there is a need to support multi-flow without updating source IP, what about to support various modes as "--txonly-multi-flow=XXX", where XXX can be src_ip, dst_ip, src_port, dst_port? If possible by keeping no param '--txonly-multi-flow' same as current usage (src_ip) for backward capability.. This extends testing capability and lets different platforms select different config based on their needs.