From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B767BA0093; Fri, 11 Mar 2022 10:40:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6311340140; Fri, 11 Mar 2022 10:40:47 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 9299440042; Fri, 11 Mar 2022 10:40:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646991645; x=1678527645; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=+sAhAa7gcryxbCU9i9hHaodkpOy1iaFcyoqBEj8RXcE=; b=cR9meRe7Mu0ZUbrAltKwbetoXzpUE8IBkvhybn0AZBR0bDukCC+DyIFu dhA5MaeGZ2cbjbABIo95ys6ishhhwfRDlvvYI3OfcI9Ufsn0atnvTGh4a JPtXJGifCzTM4bLlUIHNz9UGkKhNc6ph/aKyLz+3x4EIoTjS/Wn7KOrCh BiDLyOhY1PM1/VZQPA+mkWEk/WoXN6ve4M068bYpH5HFgy1dKK3a0FyOO byonhWwkoSl9bxLu0jv2ebOE0XRYpyzrJzot/TnbdypbTNZ58rMvJYbBq m19hsIy8w2KyKsEkowrqp++FQwhdOHgcCCY+oNGkTn/pDRixwRaPmpEuF A==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="237714045" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208,217";a="237714045" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2022 01:40:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208,217";a="538943868" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 11 Mar 2022 01:40:44 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 11 Mar 2022 01:40:44 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 11 Mar 2022 01:40:43 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 11 Mar 2022 01:40:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MGGfmFmnBlj19yEaaBbKvtklDZaF4ADt3n0uMwBGnFGcAoHJGECNlKkvhe7PhoCg1nC1ZqfVf7GKqwxouXwM1GtnOEPkQqRUMZPVK/y6uhe5yHzNSvzvPV1n/FKCiBAdWNXTGu5/KAcvb7446nvdAbV85252/+gsnpomtr6Fd0HpE3wAxC8HhzrkDCmwc6fZ+H1Ntg5VQMm989srx/g19E8MTp4aYU8xgwSODuIwgdtaOBo/0ledEEzw3Kvuz509W7ku/Ymlc5m8tVhRccNuk5POytpCcV5rcsIpP9+p16p21haP4X2a8Gcsvo5r/ZFBgl99LqKwKv5PXmqbiP/AdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KNR6W0r3KEalfIsRWI7/JQy4lYptc0iAt26mSdD1Uoc=; b=BNlmCGAYLFGPoG/l9PmqKfbl5Ss841c+6Q1yGpXhi4X+AlSdA3aAEZxoHT27g75Rw7+RhzumxZsBTV5fShng5Q9s75D3sTFRcWRWpVZSqT9K+xmSMgc/c9NLFcgut0ZW787AQbx2DMynLV7IL3Id7OL2aqqD9Y6LizbBxbq5lGHKVJjhahMpLcoDON3D9GPUH1pHq0twp9hJM2V/CRgMQulGHWOVzm5+kxkglMLysCm1Hsev3GR8v+1pPlVBoxAUQvjFtsLu2gA7W7BbeHaWYX/ywGYL8XMZ13hdsUOnp2/JHADCCyC3M9GB/oEiYkBHYXOl2OW6c08DxRpTSWTwhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by DM6PR11MB3930.namprd11.prod.outlook.com (2603:10b6:5:197::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Fri, 11 Mar 2022 09:40:42 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::bcb3:2b8:38c7:1567]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::bcb3:2b8:38c7:1567%3]) with mapi id 15.20.5061.024; Fri, 11 Mar 2022 09:40:41 +0000 Content-Type: multipart/alternative; boundary="------------BGFL26g3G4C0Jk53RuPEkX4G" Message-ID: <6c5c6289-16ce-80cd-0f79-5624ab734e40@intel.com> Date: Fri, 11 Mar 2022 15:10:33 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] app/testpmd: fixed using strtoull with 64-bit variables Content-Language: en-US To: Adham Masarwah , CC: , , , , References: <20220310175023.2552-1-adham@nvidia.com> <20220310175023.2552-2-adham@nvidia.com> From: "Singh, Aman Deep" In-Reply-To: <20220310175023.2552-2-adham@nvidia.com> X-ClientProxiedBy: PN3PR01CA0060.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:99::14) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28b120e2-2ab5-4058-f2d2-08da03433516 X-MS-TrafficTypeDiagnostic: DM6PR11MB3930:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O9AmW7m4PNoIOx5be5XKEnlnEE2G4bwPJr6QYY93Y8AMS/cezRb+568TeIqOi9N1WNwfE+1oKBGQUWdePgatQ+Fqivl/blpq25DXPgGqBviMhARi59kY4Lto1ARpYJaEholtDA6mNfPfQcx6vaEaFfhSHAkNEexE7nXGzLFHV2VEyNlvBhK3GHj+5mmnXbT0Dnz7uTIdT8dcuyy1Cte3HURZq/lZneb6q4sJtw7hxdMVoj+Ag3/OluCmygdm8TbIKxh6mXFkOOd0sKgdYeZO04TfdZ/4jBa1Jpd6LD+c2AVjbs6uSpRdZtTmgQhcD2BtVEM/SqY3YIBrebjrByofjP9AnYE5n8a8y9VpHF9pPdfA10q3DbCI3jdYXmvy8KT8oGnI9UnKJh4mhRFS2jh1qyDKNQD3FMVl+EUYezR/BklfD/bPdHoyL9dMY2FUKg1Dj5yYH/HTqiTvzJ2P+q28J/KyeYV0ahaGevuX6Fk9dhRHdmwq9ESe+45bS5NX3eO/nhgGN84inObv474/PiLNz88VRkEoXG+hIdto159l3Y0twwcCDpx9c2GaOKyYtDuRLLODhwjZ0WbuiIYVBm5p2y5flf8v/R1/W2LHa3XDZb/hptptkptZvI0O+NMZqz4Vt+yx/V+zp4j/4L1i+eE4N+I+pjUWp8uP7I587yql2IhAJl8VylXtLJJ9YY06IXVAXuwoxoGMEd6Os7iilbYy7wOjVc1FG5jhf4uQ5WE9okg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(38100700002)(31696002)(8936002)(2906002)(86362001)(316002)(6512007)(186003)(26005)(2616005)(508600001)(6486002)(6666004)(53546011)(6506007)(33964004)(66556008)(66476007)(66946007)(8676002)(4326008)(83380400001)(36756003)(31686004)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekFjc0pGRFZwc3Z1K0ZiSXdNbmZmcmdOWklYZWVxSmJMNDlOM0puVGdQU1RP?= =?utf-8?B?bFEwenlHaytNT2VyN1pvOEt1UnVSWXdDN3MyYnNZMlRBcnl2S2JxZGdqUmlF?= =?utf-8?B?QVQvZEhtai9ueEFtZk5qUko1dWhZZW5QWEU5R1o0YkdkSEthTCtMaHRUUFl5?= =?utf-8?B?NDIrSnFyaWlwY3hCS09KRUZreXZLTDNGM242TnZZWE8vZXRWL3paZ29VTHdF?= =?utf-8?B?RkRkaURxL01WMExRTURJTFZwZkRrVVZtaXovTmcwQkZBQTlpSjZnNmpYNWpJ?= =?utf-8?B?alRYSGRpeEVGUkhTSmFxN0JnL29OdVhWOXpVbGVHbUc3aGhTZnZMUnRzaEdh?= =?utf-8?B?cDFJNlc0ajQyTTFLRzVkNVZkM3JibDlPWTdyUUdBcm5PSzZMRUVPR0Fnc2NN?= =?utf-8?B?V2pKeWtkZ1NYZ2ZUVGpzdit3UUwzQ2VtdGkyb2t4eGVkTmxtb1h6WElEUmo5?= =?utf-8?B?c2Fka0w3c1MwQnN0UmhQWEx0dVlqeUE0R3JhclZMbkRKUGZWWFlSMFY2eGtM?= =?utf-8?B?Q3VkSG9BTjQ0WWdLVUsraEQrYVRvWTZ6VWF5WDJQbjdDcU9NYkVrc0FIais5?= =?utf-8?B?ZGF6TEZrRzVZOEJzTVcvVnV6K1RyRFJqRlpWVE5mQlE5TjR4TUVMMGdwTG5s?= =?utf-8?B?ZGFmYXREUERZRGhNV010TWg0RVFMSGJXN3ZDUkpKUkc4WGd5cSsxQ2ZOM1J2?= =?utf-8?B?REtKRnd5ejRzUGd2aEZsODZGV08xNTNPcmRZMW15cUk0bGNqdVF1bzEzbzg1?= =?utf-8?B?NjhkcWNvanZrQ1Yxb3J3eDdPTllIZEYvUmtsTEI0bGdmekNET3VvZjRLZE5I?= =?utf-8?B?ZUx1anlSazVySUpWdUo2T1FhOUwvcnR1S0hrNm1tblNEbzE2dWUrTU12RUZr?= =?utf-8?B?TGV0U3hTdkdlTXNPSExORnJxU21xU2s1ajlPUndodjk3eXZwZDNZSTNJbXR6?= =?utf-8?B?UmszQy9PK0ZPY01ETFZjMjMvNnBxY1gvT1ZqYVlMbkVnM3VJOVFGUmdyQTJD?= =?utf-8?B?UFVJajlQU3J5dTdMaUVRbEw2TEpORGpYMUJjQ0hNVzVvaWY4bVJsb2ZjMmQz?= =?utf-8?B?aDg1a3ZJMkl0SHdjSkJxOUdzV3FOS1YzSVZxU3FCQktYcmFrd01qRHYxYUI5?= =?utf-8?B?UUFHb0lMMHYyVnJHKzU0b0VQaE12Mi9BUmROT3E5TFdpVE1xUWRKR0pRWEVF?= =?utf-8?B?QlFqSVBXejlqK2wvbTRFTlVvajNCQ3RlZHVOMFNLZjJ4QlZod1BMbVhNTmYr?= =?utf-8?B?MndXN0ZXWk16SGFUZHp5L2tBaXdUdkpEVWJiTjltMTVSYWJQQXFJS0tiNGhR?= =?utf-8?B?T3BsUHcvaC9zTUpVR0NGU2M2dGtZZmREUDVGRkovUmlpQnRpUXd1MVNvUThj?= =?utf-8?B?ZUsycXZJanpPYTBnL1ZPOXpQdUZBVnprSWh2cXYrNTNrRXF1c29hS0xSQTJ2?= =?utf-8?B?U0JJN2xXT0JpSUhiYzNmdnU5Y0pIVk9XVUQwYTR3KzVZTlQvbXZ5UHdDdG42?= =?utf-8?B?OHNWRThPVFJGdEpLSnlvd3d1cjIzNzhyVytkODJSRm9QMk5XeTR1cHBhNy84?= =?utf-8?B?ZjZiRkVKdUJRNVdCL0xtYUpKc2ZZdm4zQ3c3N1MwOGxienpXVk9COEt6K09F?= =?utf-8?B?V1dIMC8rMTlvMDJJZXQ3QkVLbExUd0JoaUxwTWc0djVvcHRXVEtxemJCTkJ4?= =?utf-8?B?NUorK3RQZlYwaldvVG9aeFFQdWdGSWMyTVlVRk4vNWkvSHpMRUtnQmtkZFRH?= =?utf-8?B?MlFoNFBrcytoZzVoODVoc1ZuREZpcS84WC8ydTdWQVB1OUFoTVRkbTNxWURU?= =?utf-8?B?cXdQSzZXWjZFd2Q1TTFwK0h5UnFJaS9veUlwT211QUJQRUdqZW5mWFAyMW9w?= =?utf-8?B?Ym16eXF2eFRRYXJ4Mk1ocTN1T0R1Vjloc3Mranc1dkRNQk53WlZvMlI3a2Na?= =?utf-8?B?RTMxQVVMZ0hCTmJjcE0wUzRUY2RTUWw5bWhVZlk5MnNxcVgzQ1NrUVMrVU1D?= =?utf-8?B?b3JBRXQ3NFJ3PT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: 28b120e2-2ab5-4058-f2d2-08da03433516 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 09:40:41.8953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FJb7cn6NuyXjCzFiZOXBidO0LMAEXk5xIuT0b4bAUc+L9zob+e5PdIUeYqi86Sfx2t8HS6FzGWDSd0AMfbHUVjngzQxrFZwG0/mX055XOXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3930 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------BGFL26g3G4C0Jk53RuPEkX4G Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 3/10/2022 11:20 PM, Adham Masarwah wrote: > Replaced using strtoul with strtoull when converting to > 64-bit mask field. > In Windows strtoul returns 32-bit values which cause an > issue with show RSS reta. > > Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table") > Cc:stable@dpdk.org > > Signed-off-by: Adham Masarwah > --- Acked-by: Aman Singh As Windowuses the|LLP64 data model.| > app/test-pmd/cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index b4ba8da2b0..efa02bd301 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf, > return -1; > } > for (i = 0; i < ret; i++) > - conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0); > + conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0); > > return 0; > } --------------BGFL26g3G4C0Jk53RuPEkX4G Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 3/10/2022 11:20 PM, Adham Masarwah wrote:
Replaced using strtoul with strtoull when converting to
64-bit mask field.
In Windows strtoul returns 32-bit values which cause an
issue with show RSS reta.

Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
Cc: stable@dpdk.org

Signed-off-by: Adham Masarwah <adham@nvidia.com>
---


Acked-by: Aman Singh <aman.deep.singh@intel.com>

As Window uses the LLP64 data model.


 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4ba8da2b0..efa02bd301 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,
 		return -1;
 	}
 	for (i = 0; i < ret; i++)
-		conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0);
+		conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0);
 
 	return 0;
 }
--------------BGFL26g3G4C0Jk53RuPEkX4G--