DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] app/testpmd: fixed using strtoull with 64-bit variables
@ 2022-03-10 17:50 Adham Masarwah
  2022-03-10 17:50 ` Adham Masarwah
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Adham Masarwah @ 2022-03-10 17:50 UTC (permalink / raw)
  To: dev; +Cc: thomas, talshn, tamerh, idanhac, stable

Replaced using strtoul with strtoull when converting to
64-bit mask field.
In Windows strtoul returns 32-bit values which cause an
issue with show RSS reta.

Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
Cc: stable@dpdk.org

Signed-off-by: Adham Masarwah <adham@nvidia.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4ba8da2b0..efa02bd301 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,
 		return -1;
 	}
 	for (i = 0; i < ret; i++)
-		conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0);
+		conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0);
 
 	return 0;
 }
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-03-14 20:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 17:50 [PATCH] app/testpmd: fixed using strtoull with 64-bit variables Adham Masarwah
2022-03-10 17:50 ` Adham Masarwah
2022-03-11  9:40   ` Singh, Aman Deep
2022-03-14 20:25     ` Thomas Monjalon
2022-03-13 12:45 ` [PATCH v2] app/testpmd: fix show RSS RETA on Windows Adham Masarwah
2022-03-13 12:57 ` [PATCH v3] " Adham Masarwah
2022-03-13 13:21   ` Tal Shnaiderman
2022-03-14 20:27     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).