From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Bei Sun <bei.sun@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2 11/12] net/bnxt: set VLAN strip mode before default vnic cfg
Date: Tue, 25 Sep 2018 12:34:15 +0100 [thread overview]
Message-ID: <6c6f72c7-a3ee-c1b0-d675-e1095db3685c@intel.com> (raw)
In-Reply-To: <20180922045559.27438-12-ajit.khaparde@broadcom.com>
On 9/22/2018 5:55 AM, Ajit Khaparde wrote:
> From: Bei Sun <bei.sun@broadcom.com>
>
> Firmware sets pf pair in default vnic cfg. If the VLAN strip
> setting is not available at this time, it will not be
> configured correctly in the CFA.
> Set the desired VLAN strip mode before default vnic configuration.
vnic used as uppercase in prev patch titles, can you please make usage consistent?
>
> Signed-off-by: Bei Sun <bei.sun@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index e1b684c2e..e605df424 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -202,7 +202,9 @@ static int bnxt_init_chip(struct bnxt *bp)
> struct bnxt_rx_queue *rxq;
> struct rte_eth_link new;
> struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(bp->eth_dev);
> + struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
> struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
> + uint64_t rx_offloads = dev_conf->rxmode.offloads;
> uint32_t intr_vector = 0;
> uint32_t queue_id, base = BNXT_MISC_VEC_ID;
> uint32_t vec = BNXT_MISC_VEC_ID;
> @@ -283,6 +285,16 @@ static int bnxt_init_chip(struct bnxt *bp)
> }
> }
>
> + /*
> + * Firmware sets pf pair in default vnic cfg. If the VLAN strip
> + * setting is not available at this time, it will not be
> + * configured correctly in the CFA.
> + */
> + if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
> + vnic->vlan_strip = true;
> + else
> + vnic->vlan_strip = false;
> +
> rc = bnxt_hwrm_vnic_cfg(bp, vnic);
> if (rc) {
> PMD_DRV_LOG(ERR, "HWRM vnic %d cfg failure rc: %x\n",
>
next prev parent reply other threads:[~2018-09-25 11:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180901043254.51000-1-ajit.khaparde@broadcom.com>
2018-09-01 4:32 ` [dpdk-dev] [PATCH 1/7] net/bnxt: get rid of ff pools array and use the vnic info array Ajit Khaparde
2018-09-19 9:05 ` Ferruh Yigit
2018-09-19 9:21 ` Ferruh Yigit
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 00/12] bnxt patchset Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 01/12] net/bnxt: get rid of ff pools array and use the vnic info array instead Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 02/12] net/bnxt: fix uninitialized ptr access in transmit handler Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 03/12] net/bnxt: fix MTU setting Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 04/12] net/bnxt: update HWRM version Ajit Khaparde
2018-09-25 11:39 ` Ferruh Yigit
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 05/12] net/bnxt: add support for extended port counters Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 06/12] net/bnxt: add support to enable new mailbox channel Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 07/12] net/bnxt: add support for trusted VF Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 08/12] net/bnxt: use correct macro to register VF async event completion ring Ajit Khaparde
2018-09-25 11:30 ` Ferruh Yigit
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 09/12] net/bnxt: set MAC filtering as outer for non tunnel frames Ajit Khaparde
2018-09-25 11:33 ` Ferruh Yigit
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 10/12] net/bnxt: set a VNIC as default only once Ajit Khaparde
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 11/12] net/bnxt: set VLAN strip mode before default vnic cfg Ajit Khaparde
2018-09-25 11:34 ` Ferruh Yigit [this message]
2018-09-22 4:55 ` [dpdk-dev] [PATCH v2 12/12] net/bnxt: remove excess log messages Ajit Khaparde
2018-09-25 11:35 ` Ferruh Yigit
2018-09-25 11:37 ` [dpdk-dev] [PATCH v2 00/12] bnxt patchset Ferruh Yigit
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 00/15] " Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 01/15] net/bnxt: get rid of ff pools and use VNIC info array Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 02/15] net/bnxt: fix uninitialized ptr access in transmit handler Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 03/15] net/bnxt: fix MTU setting Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 04/15] net/bnxt: update HWRM version Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 05/15] net/bnxt: update HWRM version part 2 Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 06/15] net/bnxt: update HWRM version part 3 Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 07/15] net/bnxt: add support for extended port counters Ajit Khaparde
2018-09-29 1:59 ` [dpdk-dev] [PATCH v3 08/15] net/bnxt: add support to enable new mailbox channel Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 09/15] net/bnxt: add support for trusted VF Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 10/15] net/bnxt: fix registration of VF async event completion ring Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 11/15] net/bnxt: set MAC filtering as outer for non tunnel frames Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 12/15] net/bnxt: set a VNIC as default only once Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 13/15] net/bnxt: set VLAN strip mode before default VNIC cfg Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 14/15] net/bnxt: remove excess log messages Ajit Khaparde
2018-09-29 2:00 ` [dpdk-dev] [PATCH v3 15/15] net/bnxt: reduce the polling interval for valid bit Ajit Khaparde
2018-10-02 8:25 ` [dpdk-dev] [PATCH v3 00/15] bnxt patchset Ferruh Yigit
2018-10-02 16:44 ` Ajit Khaparde
2018-10-03 9:48 ` Ferruh Yigit
2018-09-01 4:32 ` [dpdk-dev] [PATCH 2/7] net/bnxt: fix uninitialized ptr access in transmit handler Ajit Khaparde
2018-09-19 9:23 ` Ferruh Yigit
2018-09-01 4:32 ` [dpdk-dev] [PATCH 3/7] net/bnxt: fix MTU setting Ajit Khaparde
2018-09-01 4:32 ` [dpdk-dev] [PATCH 4/7] net/bnxt: update HWRM version Ajit Khaparde
2018-09-01 4:32 ` [dpdk-dev] [PATCH 5/7] net/bnxt: add support for extended port counters Ajit Khaparde
2018-09-01 4:32 ` [dpdk-dev] [PATCH 6/7] net/bnxt: add support to enable new mailbox channel Ajit Khaparde
2018-09-01 4:32 ` [dpdk-dev] [PATCH 7/7] net/bnxt: add support for trusted VF Ajit Khaparde
2018-09-19 9:26 ` [dpdk-dev] [PATCH 0/7] bnxt patchset Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6f72c7-a3ee-c1b0-d675-e1095db3685c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bei.sun@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).