From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id ADFCC99D5 for ; Thu, 25 May 2017 20:31:19 +0200 (CEST) Received: from pps.filterd (m0048193.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4PIEsaL029318; Thu, 25 May 2017 11:31:18 -0700 Received: from hq1wp-exmb11.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 2ap0cq1gc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 May 2017 11:31:18 -0700 Received: from HQ1WP-EXMB13.corp.brocade.com (10.70.20.187) by Hq1wp-exmb11.corp.brocade.com (10.70.20.185) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 25 May 2017 11:31:17 -0700 Received: from HQ1WP-EXMB11.corp.brocade.com (10.70.20.185) by HQ1WP-EXMB13.corp.brocade.com (10.70.20.187) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 25 May 2017 11:31:16 -0700 Received: from HQ1WP-EXMB11.corp.brocade.com ([fe80::4534:b177:107a:bcd8]) by Hq1wp-exmb11.corp.brocade.com ([fe80::4534:b177:107a:bcd8%20]) with mapi id 15.00.1210.000; Thu, 25 May 2017 11:31:16 -0700 From: Nachi Prachanda To: Shrikrishna Khare , Chas Williams III CC: "dev@dpdk.org" , "skhare@vmware.com" Thread-Topic: [PATCH 1/6] net/vmxnet3: retain counters on restart Thread-Index: AQHS0MkzpBsFEhL6cUyruWMDn/u8kqIEd+MAgADu0yA= Date: Thu, 25 May 2017 18:31:16 +0000 Message-ID: <6c785a5767ff466293523fbc88c901f0@Hq1wp-exmb11.corp.brocade.com> References: <1495216560-12920-1-git-send-email-ciwillia@brocade.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.120.21.171] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-05-25_14:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705250332 Subject: Re: [dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 18:31:20 -0000 > From: Shrikrishna Khare [mailto:skhare@shri-linux.eng.vmware.com] > Sent: Wednesday, May 24, 2017 2:10 PM > > On Fri, 19 May 2017, Charles (Chas) Williams wrote: > > > From: Nachiketa Prachanda > > > > Most nics like virtio, igb/ixgbe etc. don't reset counters on > > dev_start and arguably this helps in monitoring the counters across a > > longer time span with multiple device start/stops. > > vmxnet3 behavior is opposite to that and counters are reset by the > > host side implementation each time the device is restarted. > > > > Change the driver to save the counters in its private context before > > it is reset by writing CMD_ACTIVATE to REG_CMD. > > > > Signed-off-by: Nachiketa Prachanda > > This won't be able to deal with vMotion or suspend/resume? Correct - this can't deal with the VM suspend/resume unless hypervisor maintains the counter. But this patch doesn't make that behavior any worse than what it was before.