From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3D4F42C2A for ; Thu, 29 Jun 2017 12:54:00 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2017 03:53:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,280,1496127600"; d="scan'208";a="102700298" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 29 Jun 2017 03:53:58 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Stephen Hurd References: <20170629025142.19404-1-ajit.khaparde@broadcom.com> <20170629025142.19404-6-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <6c9f1d6a-2921-b67b-e039-b4005c7604fd@intel.com> Date: Thu, 29 Jun 2017 11:53:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170629025142.19404-6-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/7] net/bnxt: fix automatic clearing of VF stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2017 10:54:01 -0000 On 6/29/2017 3:51 AM, Ajit Khaparde wrote: > Add code to avoid automatic clearing of VF stats on a function > reset or a stat context free. > > Signed-off-by: Stephen Hurd > Signed-off-by: Ajit Khaparde <...> > + > +/** > + * Enable/Disable VF statistics retention > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param vf > + * VF id. > + * @param on > + * 1 - Prevent VF statistics from automatically resetting > + * 0 - Allow VF statistics to automatically reset > + * > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-EINVAL) if bad parameter. > + */ > +int rte_pmd_bnxt_set_vf_persist_stats(uint8_t port, uint16_t vf, uint8_t on); > #endif /* _PMD_BNXT_H_ */ > This patch adds a new PMD specific API, .map file should be updated too for shared library builds. This is not easy to catch because API not used anywhere, what do you think updating testpmd to use this API, which also lets testing the API?