From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 7AA517CD5 for ; Mon, 5 Mar 2018 15:33:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 06:33:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,427,1515484800"; d="scan'208";a="180004918" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga004.jf.intel.com with ESMTP; 05 Mar 2018 06:32:58 -0800 To: Vipin Varghese , dev@dpdk.org, reshma.pattan@intel.com Cc: john.mcnamara@intel.com References: <1520236631-21500-1-git-send-email-vipin.varghese@intel.com> From: Ferruh Yigit Message-ID: <6cb37db7-9efd-93de-0136-d327f41f9879@intel.com> Date: Mon, 5 Mar 2018 14:32:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520236631-21500-1-git-send-email-vipin.varghese@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 14:33:01 -0000 On 3/5/2018 7:57 AM, Vipin Varghese wrote: > dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to > the device-queue pair. Updating Makefile to check for the same. > > Signed-off-by: Vipin Varghese > --- > app/pdump/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/app/pdump/Makefile b/app/pdump/Makefile > index bd3c208..038a34f 100644 > --- a/app/pdump/Makefile > +++ b/app/pdump/Makefile > @@ -3,6 +3,10 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) > +$(error "Please enable CONFIG_RTE_LIBRTE_PMD_PCAP") > +endif pdump is enabled default, so won't this break the default build? What about moving this to lib/librte_pdump, convert $(error ..) to $(warning ..) and disable CONFIG_RTE_LIBRTE_PDUMP there? > + > ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y) > > APP = dpdk-pdump >