From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BC39FA054F;
	Mon, 15 Feb 2021 09:25:40 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1FF8D16067A;
	Mon, 15 Feb 2021 09:25:40 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 7A25C40FDF
 for <dev@dpdk.org>; Mon, 15 Feb 2021 09:25:39 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AF5367F4A0;
 Mon, 15 Feb 2021 11:25:38 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AF5367F4A0
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1613377538;
 bh=piw0ymkKHwYu27BBbWmjiIDN4siaYFCax4/iQkTZ+/Y=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=ABF+JIq8mbXXFT8mXt4lguFUskPm2Fss566E+t//uxQ5yKpNf/yGrdgtk5J/0/756
 KRCDEfrmNz28zlwIQozUFVLFWNgV8LKGFe7ipWzPF7ySGSm5gbvt8Hvi58SgIsllbY
 IFiBM5eh4gvj10jnlnoZGIFTlLFEbQ0ivYPgaxlY=
To: Xueming Li <xuemingl@nvidia.com>
Cc: dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Asaf Penso <asafp@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>
References: <1613272907-22563-1-git-send-email-xuemingl@nvidia.com>
 <1613272907-22563-5-git-send-email-xuemingl@nvidia.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <6cd1bf17-9a28-b824-0e8d-fc52251567ae@oktetlabs.ru>
Date: Mon, 15 Feb 2021 11:25:38 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <1613272907-22563-5-git-send-email-xuemingl@nvidia.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: support sub function
 representor
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 2/14/21 6:21 AM, Xueming Li wrote:
> SubFunction is a portion of the PCI device, created on demand, a SF
> netdev has its own dedicated queues(txq, rxq). A SF netdev supports
> eswitch representation offload similar to existing PF and VF
> representors.
> 
> To support SF representor, this patch introduces new devargs syntax,
> examples:
>  representor=sf0               - single SubFunction representor
>  representor=sf[1,3,5]         - single list
>  representor=sf[0-3],          - single range
>  representor=sf[0,2-6,8,10-12] - list with singles and ranges
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

What happens if I try to mix different types of representors:
A: -a DBDF,representor=sf0,representor=vf1
B: -a DBDF,representor=sf0 -a DBDF,representor=vf1
(DBDF is the same in args B in both cases).

I'm not trying to say that it must work, since most likely
hotplug will be used to add representors. But behaviour
must be consistent (error?).

The question is raised here, since it is the first patch
where the second type of representor appears.

Andrew.