DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
	"Jerin Jacob" <jerin.jacob@caviumnetworks.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 01/10] event/dsw: add DSW device registration and build system
Date: Tue, 2 Oct 2018 14:43:18 +0100	[thread overview]
Message-ID: <6ce09f6f-df2e-25f9-70ac-168484b1080e@intel.com> (raw)
In-Reply-To: <20180918124514.10615-2-mattias.ronnblom@ericsson.com>

On 9/18/2018 1:45 PM, Mattias Rönnblom wrote:
> This patch contains the Meson and GNU Make build system extensions
> required for the Distributed Event Device, and also the initialization
> code for the driver itself.
> 
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

<...>

> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Ericsson AB
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +LIB = librte_pmd_dsw_event.a
> +
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -Wno-format-nonliteral

This is causing build warning with icc [1], can you please add the flag
conditionally as done in other samples of this flag [2].

Since this patch has already merged, can you please send an incremental fix patch?


[1]
icc: command line warning #10148: option '-Wno-format-nonliteral' not supported

[2]
https://git.dpdk.org/dpdk/tree/drivers/net/qede/Makefile?h=v18.08#n40
https://git.dpdk.org/dpdk/tree/drivers/net/i40e/Makefile?h=v18.08#n38

  reply	other threads:[~2018-10-02 13:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 12:45 [dpdk-dev] [PATCH v4 00/10] A Distributed Software Event Device Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 01/10] event/dsw: add DSW device registration and build system Mattias Rönnblom
2018-10-02 13:43   ` Ferruh Yigit [this message]
2018-10-04 11:21   ` [dpdk-dev] [PATCH v2] event/dsw: fix icc build Mattias Rönnblom
2018-10-04 14:17     ` Jerin Jacob
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 02/10] event/dsw: add DSW device and queue configuration Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 03/10] event/dsw: add DSW port configuration Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 04/10] event/dsw: add support in DSW for linking/unlinking ports Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 05/10] event/dsw: add DSW event scheduling and device start/stop Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 06/10] event/dsw: add DSW port load measurements Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 07/10] event/dsw: add load balancing to the DSW event device Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 08/10] event/dsw: let DSW event device sort events on dequeue Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 09/10] event/dsw: implement eventdev 'xstats' counters in DSW Mattias Rönnblom
2018-09-18 12:45 ` [dpdk-dev] [PATCH v4 10/10] event/dsw: include DSW event device documentation Mattias Rönnblom
2018-09-19 11:53 ` [dpdk-dev] [PATCH v4 00/10] A Distributed Software Event Device Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ce09f6f-df2e-25f9-70ac-168484b1080e@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=mattias.ronnblom@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).