From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93DD3A0542; Mon, 29 Aug 2022 08:53:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B2DB4113C; Mon, 29 Aug 2022 08:53:04 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id B52154069F for ; Mon, 29 Aug 2022 08:53:02 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id r22so6885756pgm.5 for ; Sun, 28 Aug 2022 23:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc; bh=4ZJ4Sk88Us/sfQrlSfC2jcB4ds4pvtdOU6jsWquSGME=; b=c//HTtZ/XyhLTqkh3q/IdAHeXPeVuMMr3l4Ol1XEEryaeYYY/TXls8hbQH/EiWQAmY 1UH3z22hnu6rW50921SYUxKq5hY5Vp0TmzYCnADVv/QHVrj9TTAEXX3bw/7i1JH5McOC PDOZgz+14UQXczmBAYjSIbJifudD2TQMenbIZnMQmJ8FQENI+dlh2/1dqrQVM+80ta3j 2tWjTsp+DwqsG3/wPP7xqvwPe4nq2S9h319Od6PFdlBl1XFUkOY1jSicIEo8qNZRTIyD TsIKyRcI1KxeHvvy1wGqHf7V1jSmkmEKs3RpRehDwgT+2dBaTckLwT0C5X62atOJncx0 tOdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc; bh=4ZJ4Sk88Us/sfQrlSfC2jcB4ds4pvtdOU6jsWquSGME=; b=FUGUjQ/oQw/HberhTF4KmI/PMMrFmcXZ1xmynEYsRF9W1fXFb79ZX/b4prXxyC76io 7hhyc7aH/jfOon1XD4bzF/x/QEsxpSfl0LXV7RTT7Dug1LaU+up1gEzXmJ/2CFPutRYV EgwWM+dxsK7ZoK5ZVPICyIyKJRE2heLmG+8GPQGvJJYj/pm9Pqmt7VoWrLD+joQUdxW9 Ouxus4u9ljkqrCpiWsm4Xt7fZinVYKltLzBVFZSAf5VdTnc4bMrcH8qhuKPYUiPORb59 tSGLeM9+ikaic0fgxmYGPi4W5e4cYLwCEeOfgi8dA5F5gYbsyB0ahqsw38W0o5gaP0OB CkMg== X-Gm-Message-State: ACgBeo3WCLTXvwx6LmwZDchQ/hapzXX8lqctXRF9EoYaALFhBc7LvKOD 46pXPG9pamZWdV4IbKWouohzUw== X-Google-Smtp-Source: AA6agR5n7rgZnd7NZpL8Ttfqex2OxyznZqI3mbyBn3SBypfSjHn05UZMPLUsOXOnf8RQxf/d5GiIfA== X-Received: by 2002:a63:145:0:b0:42c:1f56:2799 with SMTP id 66-20020a630145000000b0042c1f562799mr2948417pgb.154.1661755981919; Sun, 28 Aug 2022 23:53:01 -0700 (PDT) Received: from [10.192.0.6] ([199.101.192.129]) by smtp.gmail.com with ESMTPSA id z10-20020a6552ca000000b0041c30def5e8sm5687702pgp.33.2022.08.28.23.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Aug 2022 23:53:01 -0700 (PDT) Subject: Re: [EXT] [PATCH 0/3] Add uadk compression and crypto PMD To: Akhil Goyal , Declan Doherty , Fan Zhang , Ashish Gupta , Ray Kinsella Cc: "dev@dpdk.org" , acc@openeuler.org References: <20220620123544.3168-1-zhangfei.gao@linaro.org> From: Zhangfei Gao Message-ID: <6cfc9260-7c41-c06d-6592-5f5821e2a678@linaro.org> Date: Mon, 29 Aug 2022 14:52:49 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Akhil On 2022/8/28 下午9:02, Akhil Goyal wrote: >> UADK compression PMD provides poll mode compression & decompression >> driver >> UADK crypto PMD provides poll mode driver >> All cryptography operations are using UADK crypto API. >> All compression operations are using UADK compress API. >> >> Hardware accelerators using UADK are supposed to be supported. >> Currently supported hardware platforms: >> HiSilicon Kunpeng920 and Kunpeng930 >> >> Test: >> sudo dpdk-test --vdev=compress_uadk >> sudo dpdk-test --vdev=crypto_uadk >> >> v1: >> Target to DPDK 22.11 >> Rebased on http://git.dpdk.org/next/dpdk-next-crypto/ >> >> Suggested from Akhil Goyal >>> Current release cycle is DPDK-22.07 for which this patchset is late. >>> As we had the V1 deadline last month. >>> This patchset can go for next release cycle which is 22.11. >> Zhangfei Gao (3): >> compress/uadk: add uadk compression PMD >> test/crypto: add cryptodev_uadk_autotest >> crypto/uadk: add uadk crypto PMD >> >> app/test/test_cryptodev.c | 7 + >> app/test/test_cryptodev.h | 1 + >> doc/guides/compressdevs/index.rst | 1 + >> doc/guides/compressdevs/uadk.rst | 60 ++ >> doc/guides/cryptodevs/index.rst | 1 + >> doc/guides/cryptodevs/uadk.rst | 70 ++ >> drivers/compress/meson.build | 1 + >> drivers/compress/uadk/meson.build | 28 + >> drivers/compress/uadk/uadk_compress_pmd.c | 489 +++++++++ >> drivers/compress/uadk/version.map | 3 + >> drivers/crypto/meson.build | 1 + >> drivers/crypto/uadk/meson.build | 28 + >> drivers/crypto/uadk/uadk_crypto_pmd.c | 1137 +++++++++++++++++++++ >> drivers/crypto/uadk/version.map | 3 + >> 14 files changed, 1830 insertions(+) >> create mode 100644 doc/guides/compressdevs/uadk.rst >> create mode 100644 doc/guides/cryptodevs/uadk.rst >> create mode 100644 drivers/compress/uadk/meson.build >> create mode 100644 drivers/compress/uadk/uadk_compress_pmd.c >> create mode 100644 drivers/compress/uadk/version.map >> create mode 100644 drivers/crypto/uadk/meson.build >> create mode 100644 drivers/crypto/uadk/uadk_crypto_pmd.c >> create mode 100644 drivers/crypto/uadk/version.map >> > Please split the series into two - crypto pmd and compression pmd. > And split each of the PMD into logical small (individually compiled) patches. > > Update MAINTAINERS file > Update documentation in doc/guides/cryptodevs/features/uadk.ini > and doc/guides/compressdevs/features/uadk.ini Thanks for the suggestion. > > Also UADK does not look to be a PMD name. It is some development kit > Outside of DPDK. Can you rename it to something else? > > Is there some dependency to build it using external libraries etc? > Can you explain what exactly is UADK? UADK is a framework for user application to access hardware accelerator . https://github.com/Linaro/uadk/blob/master/docs/wd_design.md UADK relies on SVA (Shared Virtual Address) that needs to be supported by IOMMU. As a result, user application can directly use virtual address for dma, since iommu and mmu share the same virtual address by coping the same page table, which enhance the performance as well as easy usability. UADK provide algorithm libraries and api for application to use. The library will find the real hardware in the platform. We also provide openssl engine for uadk, https://github.com/Linaro/uadk_engine For alignment, we planned to provide uadk dpdk pmd as well, with the name as UADK. What do you think. Thanks.