From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 942132C66 for ; Fri, 31 Mar 2017 16:51:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490971888; x=1522507888; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=w3nedmwS2VI/0pEyxQLadgkI1brnWLDiEOtNPG7hA3E=; b=BeFYY5l65+EsjV0yrmBpIG+JgyT7cE+RxUx80EQ0BXLwXYzlPqTynPyh NM2alSMEsGwEm7M5w0USgyanbNwDYQ==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 07:51:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208";a="840431719" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2017 07:51:22 -0700 To: Ed Czeck , dev@dpdk.org References: <1490749485-1407-1-git-send-email-ed.czeck@atomicrules.com> <1490823145-13012-1-git-send-email-ed.czeck@atomicrules.com> Cc: john.miller@atomicrules.com, shepard.siegel@atomicrules.com, stephen@networkplumber.org From: Ferruh Yigit Message-ID: <6cfeef15-f882-fd47-ed81-6aecf5da2097@intel.com> Date: Fri, 31 Mar 2017 15:51:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490823145-13012-1-git-send-email-ed.czeck@atomicrules.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 1/7] net/ark: stub PMD for Atomic Rules Arkville X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 14:51:29 -0000 On 3/29/2017 10:32 PM, Ed Czeck wrote: > Enable Arkville on supported configurations > Add overview documentation > Minimum driver support for valid compile > Arkville PMD is not supported on ARM or PowerPC at this time > > v6: > * Address review comments > * Unify messaging, logging and debug macros to ark_logs.h > > v5: > * Address comments from Ferruh Yigit > * Added documentation on driver args > * Makefile fixes > * Safe argument processing > * vdev args to dev args > > v4: > * Address issues report from review > * Add internal comments on driver arg > * provide a bare-bones dev init to avoid compiler warnings > > v3: > * Split large patch into several smaller ones > > Signed-off-by: Ed Czeck > Signed-off-by: John Miller Hi Ed, Can you please update release notes [1] to announce the ARK PMD? Apart from that, overall PMD looks good to me. Still I suggest pushing the PMD integration to RC2 phase, to give more chance for reviews. If PMD gets acked before that time, we can integrate earlier. If there is no objection till RC2, it gets merged in RC2. This means less time for testing after integration, is merging on RC2 will leave you enough time for testing? Thanks, ferruh [1] doc/guides/rel_notes/release_17_05.rst