From: "Hunt, David" <david.hunt@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Cc: liang.j.ma@intel.com, "stable@dpdk.org" <stable@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode
Date: Wed, 6 Feb 2019 16:24:45 +0000 [thread overview]
Message-ID: <6d0a240c-3e8f-09d3-1f80-952cfbbd30be@intel.com> (raw)
In-Reply-To: <50a2c41a-aa5f-0d88-e227-3286ea940e02@redhat.com>
Hi Kevin,
On 6/2/2019 3:47 PM, Kevin Traynor wrote:
> On 01/07/2019 02:40 PM, David Hunt wrote:
>> The cpufreq test breakes when the system is using the intel_pstate
>> driver for frequency management. The power library has recentyly been
>> updated to allow use of the intel_pstate driver, this patch fixes the
>> cpufreq test so that it can now use either acpi or pstate modes.
>> The library will auto-detect, and set the environment appropriately.
>>
>> Fixes: ed7c51a6a680 ("app/test: vm power management")
>>
> I think this should have been:
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
>
> Presumably based on the Fixes tag, it got a stable tag added also, but
> it does not look correct for 18.11 and breaks the build. If that's
> incorrect, please let me know.
>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
You are correct. Your suggested Fixes: line is the correct one. It's
only relevant after the pstate compatibility was added.
Regards,
Dave.
prev parent reply other threads:[~2019-02-06 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 14:40 David Hunt
2019-01-14 23:03 ` Thomas Monjalon
2019-02-06 15:47 ` Kevin Traynor
2019-02-06 16:24 ` Hunt, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0a240c-3e8f-09d3-1f80-952cfbbd30be@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=liang.j.ma@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).