From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C26DA1B396; Wed, 6 Feb 2019 17:24:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2019 08:24:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,340,1544515200"; d="scan'208";a="136378149" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.210.33]) ([10.237.210.33]) by orsmga001.jf.intel.com with ESMTP; 06 Feb 2019 08:24:46 -0800 To: Kevin Traynor , dev@dpdk.org Cc: liang.j.ma@intel.com, "stable@dpdk.org" , Thomas Monjalon References: <20190107144051.7097-1-david.hunt@intel.com> <50a2c41a-aa5f-0d88-e227-3286ea940e02@redhat.com> From: "Hunt, David" Message-ID: <6d0a240c-3e8f-09d3-1f80-952cfbbd30be@intel.com> Date: Wed, 6 Feb 2019 16:24:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <50a2c41a-aa5f-0d88-e227-3286ea940e02@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 16:24:50 -0000 Hi Kevin, On 6/2/2019 3:47 PM, Kevin Traynor wrote: > On 01/07/2019 02:40 PM, David Hunt wrote: >> The cpufreq test breakes when the system is using the intel_pstate >> driver for frequency management. The power library has recentyly been >> updated to allow use of the intel_pstate driver, this patch fixes the >> cpufreq test so that it can now use either acpi or pstate modes. >> The library will auto-detect, and set the environment appropriately. >> >> Fixes: ed7c51a6a680 ("app/test: vm power management") >> > I think this should have been: > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > > Presumably based on the Fixes tag, it got a stable tag added also, but > it does not look correct for 18.11 and breaks the build. If that's > incorrect, please let me know. > >> Signed-off-by: David Hunt You are correct. Your suggested Fixes: line is the correct one. It's only relevant after the pstate compatibility was added. Regards, Dave.