From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BD1F02BD3 for ; Thu, 22 Mar 2018 11:21:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 03:21:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,344,1517904000"; d="scan'208";a="41204726" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.63]) ([10.237.221.63]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2018 03:21:07 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Ivan Malov References: <1516899647-8541-1-git-send-email-arybchenko@solarflare.com> <1521631701-11282-1-git-send-email-arybchenko@solarflare.com> <1521631701-11282-2-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <6d1ac2ef-1bc4-a2ff-fc6f-d17530671bda@intel.com> Date: Thu, 22 Mar 2018 10:21:06 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521631701-11282-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/6] eal: register log type and pick level from EAL args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 10:21:11 -0000 On 3/21/2018 11:28 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Dynamic log types are registered on RTE_INIT() step. > This allows one to set log levels by EAL options on > application launch. However, this does not allow to > manage log types if they are created during runtime. > > EAL does not store log levels and types passed from > the command line. Thus, they cannot be picked later. > This is an obvious flaw since it would be better to > be able to pick levels for dynamic types registered > for runtime-determined facilities such as NIC ports. > > This patch provides a mechanism to store log levels > passed from EAL options and adds an API to register > log types and pick levels from the internal storage. > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Acked-by: Ferruh Yigit