DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] example exception_path: cache align per CPU stats
@ 2018-02-13  3:43 Dustin Lundquist
  2018-02-13  8:40 ` Remy Horton
  0 siblings, 1 reply; 2+ messages in thread
From: Dustin Lundquist @ 2018-02-13  3:43 UTC (permalink / raw)
  To: Remy Horton; +Cc: dev, Dustin Lundquist

Align stats structure to cache line to prevent bouncing per CPU stats
structure between cache lines.

Signed-off-by: Dustin Lundquist <dustin@null-ptr.net>
---
 examples/exception_path/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c
index 280a50451..3e5b1e718 100644
--- a/examples/exception_path/main.c
+++ b/examples/exception_path/main.c
@@ -108,7 +108,7 @@ struct stats {
 	uint64_t rx;
 	uint64_t tx;
 	uint64_t dropped;
-};
+} __rte_cache_aligned;
 
 /* Array of lcore-specific stats */
 static struct stats lcore_stats[RTE_MAX_LCORE];
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] example exception_path: cache align per CPU stats
  2018-02-13  3:43 [dpdk-dev] [PATCH] example exception_path: cache align per CPU stats Dustin Lundquist
@ 2018-02-13  8:40 ` Remy Horton
  0 siblings, 0 replies; 2+ messages in thread
From: Remy Horton @ 2018-02-13  8:40 UTC (permalink / raw)
  To: dev; +Cc: Dustin Lundquist

Patch ought to also have:

Fixes: af75078fece3 ("first public release")

Otherwise looks good to me. I'm not the maintainer so have only done 
basic smoke tests.

On 13/02/2018 03:43, Dustin Lundquist wrote:
[..]
> Signed-off-by: Dustin Lundquist <dustin@null-ptr.net>
> ---
>  examples/exception_path/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Remy Horton <remy.horton@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-13  8:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-13  3:43 [dpdk-dev] [PATCH] example exception_path: cache align per CPU stats Dustin Lundquist
2018-02-13  8:40 ` Remy Horton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).