From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Creeley, Brett" <brett.creeley@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode
Date: Thu, 4 Feb 2021 14:00:16 +0000 [thread overview]
Message-ID: <6d1dffe9fa664846a1da530af68e82c5@intel.com> (raw)
In-Reply-To: <20210204125029.14138-1-haiyue.wang@intel.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, February 4, 2021 8:50 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Creeley,
> Brett <brett.creeley@intel.com>
> Subject: [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode
>
> In Single VLAN Mode, single VLAN filters via ICE_SW_LKUP_VLAN are based on
> the inner VLAN ID, so the VLAN TPID (i.e. 0x8100 or 0x888a8) doesn't matter.
>
> In Double VLAN Mode, outer/single VLAN filters via ICE_SW_LKUP_VLAN are
> based on the outer/single VLAN ID + VLAN TPID.
>
> For both modes, adding a VLAN 0 + no VLAN TPID filter to handle untagged
> traffic when VLAN pruning is enabled. Also, this handles VLAN 0 priority tagged
> traffic in Single VLAN Mode, since the VLAN TPID is not part of filtering.
>
> If Double VLAN Mode is enabled then an explicit VLAN 0 + VLAN TPID filter
> needs to be added to allow VLAN 0 priority tagged traffic in DVM, since the
> VLAN TPID is part of filtering.
>
> Fixes: 14e7a4b37b4f ("net/ice/base: support configuring device in double VLAN
> mode")
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2021-02-04 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 12:22 [dpdk-dev] [PATCH v1] " Haiyue Wang
2021-02-04 12:50 ` [dpdk-dev] [PATCH v2] " Haiyue Wang
2021-02-04 14:00 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1dffe9fa664846a1da530af68e82c5@intel.com \
--to=qi.z.zhang@intel.com \
--cc=brett.creeley@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).