From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 876FBA0524; Thu, 4 Feb 2021 15:00:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 704532407BA; Thu, 4 Feb 2021 15:00:23 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id C0278240714 for ; Thu, 4 Feb 2021 15:00:21 +0100 (CET) IronPort-SDR: 1XjZuNZ8ghzrNn8J9NuPKBhTxwdXnkyrMbFcFtrenOi7Rps769vqL909FK0Xm7Ls5EeaH3bHTX /Pg3EJyKic2w== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="266074017" X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="266074017" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 06:00:20 -0800 IronPort-SDR: 9kt1qq1wbZ8yLtMxhhORai+2wx8khWFBAKSIToWlAq5nVhYN/BpazQzg//jPigtlLrn/RgFsPd Sg/sPmyBhxSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="483249319" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 04 Feb 2021 06:00:19 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 06:00:18 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 4 Feb 2021 22:00:16 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Thu, 4 Feb 2021 22:00:16 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Yang, Qiming" , "Creeley, Brett" Thread-Topic: [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode Thread-Index: AQHW+vafHd1B/pbyZE+iE1srQWQxgqpIBgSg Date: Thu, 4 Feb 2021 14:00:16 +0000 Message-ID: <6d1dffe9fa664846a1da530af68e82c5@intel.com> References: <20210204122217.13707-1-haiyue.wang@intel.com> <20210204125029.14138-1-haiyue.wang@intel.com> In-Reply-To: <20210204125029.14138-1-haiyue.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Thursday, February 4, 2021 8:50 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, Haiyue ; Creeley, > Brett > Subject: [PATCH v2] net/ice: fix VLAN 0 adding based on VLAN mode >=20 > In Single VLAN Mode, single VLAN filters via ICE_SW_LKUP_VLAN are based o= n > the inner VLAN ID, so the VLAN TPID (i.e. 0x8100 or 0x888a8) doesn't matt= er. >=20 > In Double VLAN Mode, outer/single VLAN filters via ICE_SW_LKUP_VLAN are > based on the outer/single VLAN ID + VLAN TPID. >=20 > For both modes, adding a VLAN 0 + no VLAN TPID filter to handle untagged > traffic when VLAN pruning is enabled. Also, this handles VLAN 0 priority = tagged > traffic in Single VLAN Mode, since the VLAN TPID is not part of filtering= . >=20 > If Double VLAN Mode is enabled then an explicit VLAN 0 + VLAN TPID filter > needs to be added to allow VLAN 0 priority tagged traffic in DVM, since t= he > VLAN TPID is part of filtering. >=20 > Fixes: 14e7a4b37b4f ("net/ice/base: support configuring device in double = VLAN > mode") >=20 > Signed-off-by: Haiyue Wang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi