From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by dpdk.org (Postfix) with ESMTP id F243F685D for ; Tue, 17 Sep 2013 12:20:37 +0200 (CEST) Received: by mail-bk0-f49.google.com with SMTP id r7so2009047bkg.36 for ; Tue, 17 Sep 2013 03:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=y1UEGF9hlGHlHDbEWJYuu1Avpcg+hjweMp4CQXLD0tk=; b=fD9YtkPX8admOY49H/oZr8R+WgtZdG2WSKv/rSkFBtMqQvna/fRwCTTa8t/mJCSusx QX+Gx1yYFIjum8SY5UID+CohCVSA/ReROdQCSVunblol2V9cUPuLy8dnrMCgL36b1/ez 2+NuH+I1BisCvysvPZNleKoXIhCXc217r771JRZTbTVBCJvm7WS4kFCsT/iRoewhYhON psGltgqlryEJP6t7c/CONIFMYrltpvIpyLLLG8XBOYbTo+ZAeLwUbx0ld7MsWB8Eg908 2RMpGKNYM0DCnmyIq4RZspFQ6LaHjrJecWIitcgecNz/XUgdSvpdiVtqlRRwbt41nati kEbw== X-Gm-Message-State: ALoCoQnLe8m+NStUkSFAjMgu9mlH5Pr2cRFzkEa5klIGimmfu7VGof71Fd3do/5CthDyB8SMAQTw X-Received: by 10.205.74.69 with SMTP id yv5mr731186bkb.35.1379413276094; Tue, 17 Sep 2013 03:21:16 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id b6sm9661229bko.16.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 17 Sep 2013 03:21:15 -0700 (PDT) Received: by 6wind.com (sSMTP sendmail emulation); Tue, 17 Sep 2013 12:21:12 +0200 From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 17 Sep 2013 12:21:09 +0200 Message-Id: <6d68788d4315a3c2e13e244b0658429334df2572.1379413101.git.thomas.monjalon@6wind.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: References: <1379363340-20870-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 1/2] pci: do not check BAR0 mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2013 10:20:38 -0000 From: David Marchand Since DPDK 1.4, bars mapping is checked and prevent from initializing drivers which do not use igb_uio mapping. There is no need to check for bars mapping, especially BAR0 is not required. If bars mapping failed, then pci_uio_map_resource will fail and we won't reach this check. So get rid of BAR0 check. Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_pci.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c index 5c7f814..3913c65 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c @@ -963,15 +963,6 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d return -1; #endif - /* We always should have BAR0 mapped */ - if (rte_eal_process_type() == RTE_PROC_PRIMARY && - dev->mem_resource[0].addr == NULL) { - RTE_LOG(ERR, EAL, - "%s(): BAR0 is not mapped\n", - __func__); - return (-1); - } - /* reference driver structure */ dev->driver = dr; -- 1.7.10.4