From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D94CEA0547; Fri, 12 Feb 2021 12:55:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D57C22A24E; Fri, 12 Feb 2021 12:55:12 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 4DD4522A23C for <dev@dpdk.org>; Fri, 12 Feb 2021 12:55:11 +0100 (CET) IronPort-SDR: rSDp2aAeAjXNHCHYtsmu3oDAhcBltCwinAUPInYs4IWfC3T6/wrGedBZyf2p4RyqurnvZMNGrb SmTYyr/MVuvg== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="170070053" X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="170070053" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 03:55:09 -0800 IronPort-SDR: ABdPXKZQsWdbndAz8dr+cresn/MAW1kYMv66t9xT5m+YVqeLuGaCb7s1z3S2NZCpTJH2/3dP8Z ZqYDXbkHGqDA== X-IronPort-AV: E=Sophos;i="5.81,173,1610438400"; d="scan'208";a="437558980" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.3.39]) ([10.252.3.39]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 03:55:06 -0800 To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Anoob Joseph <anoobj@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com>, Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com> References: <20210211181700.1273539-1-thomas@monjalon.net> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy Message-ID: <6d6b5f40-2145-38df-6749-f3f9f581de17@intel.com> Date: Fri, 12 Feb 2021 11:55:05 +0000 MIME-Version: 1.0 In-Reply-To: <20210211181700.1273539-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: replace hugepages commands with dedicated tool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 2/11/2021 6:16 PM, Thomas Monjalon wrote: > The tool dpdk-hugepages.py, added in DPDK 20.11, > is referenced in the guides instead of more complicate commands. > > The original Linux commands are kept in linux_gsg/sys_reqs.rst > and nics/build_and_test.rst. > > Suggested-by: Stephen Hemminger <stephen@networkplumber.org> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > doc/guides/cryptodevs/octeontx.rst | 4 +--- > doc/guides/cryptodevs/octeontx2.rst | 2 +- > doc/guides/howto/lm_bond_virtio_sriov.rst | 6 +++--- > doc/guides/howto/lm_virtio_vhost_user.rst | 6 +++--- > doc/guides/linux_gsg/sys_reqs.rst | 2 ++ > doc/guides/nics/build_and_test.rst | 6 ++++++ > doc/guides/nics/mlx4.rst | 2 +- > doc/guides/nics/mlx5.rst | 2 +- > doc/guides/nics/virtio.rst | 2 +- > doc/guides/sample_app_ug/vhost.rst | 2 +- > 10 files changed, 20 insertions(+), 14 deletions(-) > > diff --git a/doc/guides/cryptodevs/octeontx.rst b/doc/guides/cryptodevs/octeontx.rst > index d813cb2974..a39f3f3d02 100644 > --- a/doc/guides/cryptodevs/octeontx.rst > +++ b/doc/guides/cryptodevs/octeontx.rst > @@ -107,9 +107,7 @@ applications. > > .. code-block:: console > > - echo 8 > /sys/kernel/mm/hugepages/hugepages-524288kB/nr_hugepages > - mkdir /mnt/huge > - mount -t hugetlbfs nodev /mnt/huge > + dpdk-hugepages.py --setup 4G --pagesize 512M > > Example applications can now be executed with crypto operations offloaded to > OCTEON TX crypto PMD. > diff --git a/doc/guides/cryptodevs/octeontx2.rst b/doc/guides/cryptodevs/octeontx2.rst > index a648a33cbc..d312eeb74c 100644 > --- a/doc/guides/cryptodevs/octeontx2.rst > +++ b/doc/guides/cryptodevs/octeontx2.rst > @@ -123,7 +123,7 @@ Another way to bind the VF would be to use the ``dpdk-devbind.py`` script: > > * Ensure that sufficient huge pages are available for your application:: > > - echo 8 > /sys/kernel/mm/hugepages/hugepages-524288kB/nr_hugepages > + dpdk-hugepages.py --setup 4G --pagesize 512M > > Refer to :ref:`linux_gsg_hugepages` for more details. > > diff --git a/doc/guides/howto/lm_bond_virtio_sriov.rst b/doc/guides/howto/lm_bond_virtio_sriov.rst > index 16d86d122c..3e25480316 100644 > --- a/doc/guides/howto/lm_bond_virtio_sriov.rst > +++ b/doc/guides/howto/lm_bond_virtio_sriov.rst > @@ -581,9 +581,9 @@ Set up DPDK in the Virtual Machine > # virtio port is 03 > # vf port is 04 > > - cat /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > - cat /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > + /root/dpdk/usertools/dpdk-hugepages.py --show > + /root/dpdk/usertools/dpdk-hugepages.py --setup 2G > + /root/dpdk/usertools/dpdk-hugepages.py --show Wouldn't be better to use 'dpdk-hugepages.py' only, or perhaps './usertools/dpdk-hugepages.py' but not full path. The dpdk path, '/root/dpdk/', assumption can be missleading.