From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 80B341B48D for ; Wed, 19 Dec 2018 11:06:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 02:06:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="108551966" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.106]) ([10.237.220.106]) by fmsmga007.fm.intel.com with ESMTP; 19 Dec 2018 02:06:00 -0800 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Ferruh Yigit Cc: dev@dpdk.org References: <20181218102643.4332-1-gaetan.rivet@6wind.com> <20181219092409.yrxltegt7e76zevy@bidouze.vm.6wind.com> From: "Burakov, Anatoly" Message-ID: <6d7f1461-3f8c-e912-3223-f37dc3d209e0@intel.com> Date: Wed, 19 Dec 2018 10:05:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181219092409.yrxltegt7e76zevy@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] mk: use misleading indentation warning when available X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 10:06:02 -0000 On 19-Dec-18 9:24 AM, Gaëtan Rivet wrote: > On Tue, Dec 18, 2018 at 02:50:30PM +0000, Ferruh Yigit wrote: >> On 12/18/2018 10:26 AM, Gaetan Rivet wrote: >>> -Wmisleading-indentation was introduced in GCC 6.0. >> >> It seems '-Wmisleading-indentation' is part of -Wall, which we already set by >> default. If so no need to explicitly add it. >> >> The link I found: >> https://www.gnu.org/software/gcc/gcc-6/porting_to.html >> >> copy-paste: >> " >> A new warning -Wmisleading-indentation was added to -Wall, warning about places >> where the indentation of the code might mislead a human reader about the control >> flow: >> " >> >> Is there a way to confirm it is part of -Wall? >> > > I think you are right, actually the check was already used. > This is worrying, given that the original bug was not seen. > > This patch can be left out then, but the problem remains. Maybe an > update to coding style is needed, or an evolution to checkpatch // > preferably something else. clang-format? It's not exactly a style *checker*, but if we had a .clang-format config file included with DPDK, it would be easy to 1) format the code properly before sending out the patches, and 2) convert the entire DPDK codebase to the new style, should such need arise. (also, uncrustify and other code beautifiers...) -- Thanks, Anatoly