From: Maxime Coquelin <maxime.coquelin@redhat.com> To: Eugenio Pérez <eperezma@redhat.com>, dev@dpdk.org Cc: Adrian Moreno Zapata <amorenoz@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, Jens Freimann <jfreimann@redhat.com>, stable@dpdk.org, Kevin Traynor <ktraynor@redhat.com> Subject: Re: [dpdk-dev] [PATCH v2 1/1] vhost: fix iotlb mempool single-consumer flag Date: Fri, 18 Sep 2020 11:49:45 +0200 Message-ID: <6dac4c66-b5fe-3f76-8531-bf1ab7df505f@redhat.com> (raw) In-Reply-To: <20200831075922.17970-2-eperezma@redhat.com> On 8/31/20 9:59 AM, Eugenio Pérez wrote: > Bugzilla bug: 523 > > Control thread (which handles iotlb msg) and forwarding > thread both use iotlb to translate address. The former may modify the > same entry of mempool and may cause a loop in iotlb_pending_entries > list. Bugzilla ID: 523 > Fixes: d012d1f293f4 ("vhost: add IOTLB helper functions") > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > --- > lib/librte_vhost/iotlb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c > index 5b3a0c090..e0b67721b 100644 > --- a/lib/librte_vhost/iotlb.c > +++ b/lib/librte_vhost/iotlb.c > @@ -321,8 +321,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int vq_index) > IOTLB_CACHE_SIZE, sizeof(struct vhost_iotlb_entry), 0, > 0, 0, NULL, NULL, NULL, socket, > MEMPOOL_F_NO_CACHE_ALIGN | > - MEMPOOL_F_SP_PUT | > - MEMPOOL_F_SC_GET); > + MEMPOOL_F_SP_PUT); > if (!vq->iotlb_pool) { > VHOST_LOG_CONFIG(ERR, > "Failed to create IOTLB cache pool (%s)\n", > I'll fix commit message while applying. Thanks for your contribution: Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Maxime
next prev parent reply other threads:[~2020-09-18 9:49 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-10 14:11 [dpdk-dev] [PATCH 0/1] " Eugenio Pérez 2020-08-10 14:11 ` [dpdk-dev] [PATCH 1/1] " Eugenio Pérez 2020-08-25 9:17 ` Kevin Traynor 2020-08-26 6:28 ` Xia, Chenbo 2020-08-26 12:50 ` Eugenio Perez Martin 2020-08-27 1:20 ` Xia, Chenbo 2020-08-28 18:40 ` Jens Freimann 2020-08-18 14:21 ` [dpdk-dev] [PATCH 0/1] " Eugenio Perez Martin 2020-08-31 7:59 ` [dpdk-dev] [PATCH v2 0/1] vhost: Make iotlb mempool not single-consumer Eugenio Pérez 2020-08-31 7:59 ` [dpdk-dev] [PATCH v2 1/1] vhost: fix iotlb mempool single-consumer flag Eugenio Pérez 2020-08-31 10:21 ` Xia, Chenbo 2020-09-18 9:49 ` Maxime Coquelin [this message] 2020-09-18 12:29 ` Maxime Coquelin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6dac4c66-b5fe-3f76-8531-bf1ab7df505f@redhat.com \ --to=maxime.coquelin@redhat.com \ --cc=amorenoz@redhat.com \ --cc=chenbo.xia@intel.com \ --cc=dev@dpdk.org \ --cc=eperezma@redhat.com \ --cc=jfreimann@redhat.com \ --cc=ktraynor@redhat.com \ --cc=stable@dpdk.org \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git