From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFB59A0C43; Fri, 22 Oct 2021 04:25:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A20E541147; Fri, 22 Oct 2021 04:25:21 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 9912E4068C; Fri, 22 Oct 2021 04:25:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229473573" X-IronPort-AV: E=Sophos;i="5.87,171,1631602800"; d="scan'208";a="229473573" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 19:25:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,171,1631602800"; d="scan'208";a="721542813" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 21 Oct 2021 19:25:18 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 19:25:17 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 21 Oct 2021 19:25:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 21 Oct 2021 19:25:17 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 21 Oct 2021 19:25:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J6v9+YRXbFzTXa/7WIZ81YwcMAqsGz09Ibe/aeLZ2lGOUEQNBGg/GrtxGXmU9zZZcshwxdfS2L379629ZGJ6lOoPZhYYXV88aGAYYv651Hzr8w3tqUB/FswXQ/+cOoXo3pL2XBFZgPZuzx5hkjfeDev4X/nYNvZS+fgTsm6cKg3ktW0WEq8XpgALTXOxwbrrG/ITyTuugXx52ElvV/o9UY207YZM7oZo3NPFJ/wHoTg89L5nBOBQdXimaRwxTzMcMiUYR9PGHxDfgKvD+VsHmMG9xALqPb6obnQMRlPLXjU8ZRuyzzBKqjJdpAchpQbESMiaiwCVaJ/m1BXZZGIUvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rW7GHnYIdg/A7pY0Iv57x7DpTM+kvyEPPSNQbD1eboY=; b=dYYzQJMLAigHmmfvTtQ3c6bMTkJFAf7eEmvU/oOUlZWxyfuXwZXWDXS9aCeV/mGV9ahIci5/Eq7JwMzG64zMotFftD3gl634SVATlxCSczQMlhJPX9MpSlW+8m/aI3+a8Lu7bVBt7Ba63bLCzGF7ByBN5jbOYCUL7UtKmb1ygpDRYlgwnrBZR+86Ya27u3yJLWSCkycv4zJ2BGfcpDARRH+0r2R+VL9/DHoYlMVp7mMiCzXVbdyocn4jmxXD6zTswq1P7uZOqsHF3zBmG01nds8RsN5MDnfo4kTIVwISF69dO+2Oj3t0sm0G++P3eNU8wkGkfEqlaUWjcANPEje7gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rW7GHnYIdg/A7pY0Iv57x7DpTM+kvyEPPSNQbD1eboY=; b=YgrrV0tMfUNHp6yJM+hY4WCYegaQCYFdlv9yIpNWIKvGrza4ow05baSgaWPiKFXCJlHw9PghdhzIh6UllfGJ6x/ePDUl6EnPxPI846vUIp6BAurbHqfrOFHGITCN2CWrmgcUiOFZAIOl43S7beyCZDd+9F2GtrzvRdYhonA2uuc= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4853.namprd11.prod.outlook.com (2603:10b6:510:40::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Fri, 22 Oct 2021 02:25:15 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 02:25:15 +0000 Message-ID: <6dad6c64-4b97-0d14-864f-3049cf320db3@intel.com> Date: Fri, 22 Oct 2021 03:25:08 +0100 Content-Language: en-US To: Eli Britstein , CC: Matan Azrad , Asaf Penso , "Slava Ovsiienko" , Thomas Monjalon , , , References: <20211021080310.9892-1-elibr@nvidia.com> <20211021132002.26231-1-elibr@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021132002.26231-1-elibr@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0201CA0002.eurprd02.prod.outlook.com (2603:10a6:4:3f::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0201CA0002.eurprd02.prod.outlook.com (2603:10a6:4:3f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Fri, 22 Oct 2021 02:25:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9cfd2b3-c213-4a5f-fee4-08d995032e83 X-MS-TrafficTypeDiagnostic: PH0PR11MB4853: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p5mt3HfK29KeGbTsks2cZkO/b6ceNoA+CFQsyvEqc4PU6P4pXif1Odjr9AQdxMDW2HoSs+NiTzCm4Z7VoNzx/OyIl2Vh7R3O7pbajyFvpQnbC++ikTVL9Ef0ZAJADFbRvM8xCFSdgfjx481NYejhaq4bTN5i1bQFcYlQjuV+1g23thuA5Sg3e3I5VJPBPbbrnJkE4HAI90K9OckSkWyFvvtawssaxiDQ7WUspNM5WMA8tSGHyhmFm8gIr0Gd8B0FJ6VqPNNeazOgM2wuynn9OomJczTnlcyK4sfbRyauE/kL7ylCpUaMe9XOpFlmLKqMDuSbFkQsRIEBR08x+5pXve5k9LiQLQ00e5eVBYp51FEWv9sNzTmR2NC66CfUONxECJJflSJMgPgjKpfqfe+OIy4sLW+St92j6EvyFcBYOl3D+AHOENMRpgRGIv1acDZBCDD2Xsrgxb3VwUBaagtHhec4hVYjHiC9SeLxSqx7LQiyQKxDzgad2WbG1e4iGks7vbpTkhp6OxvssTA2hTfN/LiH40fOQndti/7PwLZiC6y0aTpEKi5NPmiN/Kf1n5iUOsW4+eygHeyX1Wr05fTsoy03z9vohdmcPVfrT0OAV0Ei/BPCTr3nNdWlHhr0MQWK7mSmNfcQtgADLN9WQlSGy01PdPDpvWJRYuZ6aanmlb38c+TihntmbYqjbdfsHNyVdtHvvBiyZf8V46OpJ7vPAQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(8676002)(36756003)(54906003)(956004)(2616005)(186003)(86362001)(26005)(8936002)(82960400001)(66946007)(16576012)(316002)(4326008)(66476007)(66556008)(5660300002)(44832011)(38100700002)(31686004)(53546011)(4744005)(6486002)(6666004)(2906002)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm5HVGplZmVhZ3ZzMFJ5Rnd1WVlwSExCSldLUE5kV3ZVNHBVUUxHU3YwOEtM?= =?utf-8?B?ME5TbzFNUm1BSTZYQVQvVUh0K1p0Y1J4MDlHYUU0bTlqanZYK2hQZk1hSkJk?= =?utf-8?B?a1NHR0M0OWc3NHJ0UjVoWVlUWlloQXBiS2VidngyNFlUa1NKZU1hdVhzRFVp?= =?utf-8?B?bytWcTgxMzdpV0dHdjdwM2ZyWU9pL2Rnam9SMnpaaWVwd3JKa3JQYWcwaEkv?= =?utf-8?B?V0ttZWl3TlBGWGIveVpEU3FRNWRya3h0NW1jcXVsUnN6Z0hCekZta0pJanFn?= =?utf-8?B?Y3FNU1JKdVdISnFpZnQzOGJxblUremxyL285bFc4Z0tTNnVpYmZMWGhGNHpF?= =?utf-8?B?MGJhVW1RVHZxKzBWOUNBUzh6cEI5SDVJKzZWSGZlUTRrT3g4OWlOWmxtRkoz?= =?utf-8?B?eEord0oxK0R0SDFRMkQ5OUxsUVdlYUdEMDYxV3htL2Zyak5ZYWUrVHc5V1pU?= =?utf-8?B?YXh0bVBnN2QzU3pjMnIvb2Y2MmtBNmRHUTV4djdZZkRGVTNvNktaR1R5S3Q5?= =?utf-8?B?RGtHZW1wWE92eXdsbWMzM0pJdElXUW9nOEhxY1pHWWRGbzhiV2RmZTUzSnBq?= =?utf-8?B?eklaV1Y4RmkyYTJxM2FqQUNQeFMzOTZ5ZnQ3N0NKWFRvQzJScm5vVmdQWTdj?= =?utf-8?B?bDk5T2xMdzY4L2k5aWcra0V3ZWk0ZHowRFpkS0tMMllKdWVBYmRGUkpnUW1O?= =?utf-8?B?Ly9HODJRMXNLODJFTFplenFwVUdodjFlWEM4Y0lTK2RVRjg1QXByUXVpMlN6?= =?utf-8?B?SndYb1lpL2ZNNmNQb1RDamdsRzZzT0VZZlJKTmkzRlU4MHFZc2hFbUU0b2N0?= =?utf-8?B?Wmx4MllCeHp5ZVphZ2dMeHF2aEVsY3VrQ3RyNUErUHNNcTY1N0ViSVVvdE4y?= =?utf-8?B?ZC8vQlJGNlhoQ3F6WGpWRllQNGJwTmZ5eVlaR0lEcWo5YXlaKytsSnFFeFBL?= =?utf-8?B?bWp4YzZPWU5tOVBvR3gyTVZjc1N1V2JBSmJKdGUyNjZPR1JkVXZhcEQ0NFEy?= =?utf-8?B?ejA3L1pYdjh3UndzRzhTSllQNjFLNmoxaUpjbXJ6c3QrN1VGTnJRRllMMmU0?= =?utf-8?B?RHhyMVJjSDU3elpHRXhxNXU1aVRTTFNoaTE4QTNXendyZ0l0YUg1UTJxTDRJ?= =?utf-8?B?ZFJxaG91dWVMU0lwS3cyWElFdDJUb1lab3ZDTE0wN2FDbk16TkFDSm14RnlU?= =?utf-8?B?REZqMmtIY0dYZVRxYnBOYnIrcTg5Z2FPZkNzeEFrdzJGc1haNGVJWWdleGho?= =?utf-8?B?Qk1XVWxnMzlrSHVvVVB2TXZNL2ZDaVlSTkhDcE1UWkdmeDVyUWYrQWQzU1BC?= =?utf-8?B?RUpjWkVTbEkrM2hIR3Y0cldPT2ltUUtNSkRJeDVtTHVhSjY4cnNEem9zdGY4?= =?utf-8?B?VWhBTG45OTVVOGV4a0RLc3R3OXcvV3V6NlRKQUQrUHVkRDRBZzJRdW1laFhy?= =?utf-8?B?Q0tNeFNwcWU3TUQxN21BNlc2YmxNTFpNOEsvWDZDczJnczhlelZicEc2Wnp0?= =?utf-8?B?Y1d3N2EraUp1aUpWUENjamdYeFhCei9kbEEyN2JoWnpJTjdSVHlPTjRuV0NQ?= =?utf-8?B?bEhjK0oxNDR5d1RhQUlTTFFVWlJFVHh3L0FPemJGOTFoNFlCS3hKRmFqZ3Yy?= =?utf-8?B?Yk9RVHVXcWRPajVBK2hGVGdyQXBwVy9VVUp5SFdaK2J0SWNSVkpSUllpSHV4?= =?utf-8?B?NU05QlUwZWVIVTJpaG9lVFlBemJtcVJlNGg5SUErNXpBVGo4NzIyMXFEVmtM?= =?utf-8?B?RTZjdzErdWNLQnlESkJvYnd3bTluZnN6VnlWUWVSbmM0MjZVaVJEWTdtSVdU?= =?utf-8?B?NHFERVBzZHJDeHNBSFpLcFlZV2RCcWltL3lNUC9zTWducDJIQ0Rtb1ViS0JC?= =?utf-8?B?eS8yTTJjaktVcjBETE90MTBxVnlrTFd3K3pUNGFMeUh5dHdrTURpVmw3Sysr?= =?utf-8?Q?xKBa2qJFLNdTYtXSHjEvuxk9rpj2TQZt?= X-MS-Exchange-CrossTenant-Network-Message-Id: e9cfd2b3-c213-4a5f-fee4-08d995032e83 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 02:25:15.0435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4853 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH V2 1/1] app/testpmd: fix packet burst spreading stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 2:20 PM, Eli Britstein wrote: > RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts' > argument, which specifies the maximum number to receive/transmit. > It can be 0..nb_pkts, meaning nb_pkts+1 options. > Testpmd can provide statistics of the burst sizes ('set > record-burst-stats on') by incrementing an array cell of index > . This array is mistakenly [MAX_PKT_BURST] size. Receiving > the maximum burst will cause out of bound write. > Enlarge the spread stats array by one cell to fix it. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Eli Britstein > Reviewed-by: Matan Azrad > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.