From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A772F1B809 for ; Wed, 31 Jan 2018 20:11:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 11:11:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,441,1511856000"; d="scan'208";a="23929171" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.13]) ([10.252.19.13]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jan 2018 11:11:34 -0800 To: Andrew Rybchenko , Olivier Matz , dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic Cc: Thomas Monjalon References: <20180129171339.20896-1-olivier.matz@6wind.com> From: Ferruh Yigit Message-ID: <6db58723-233e-91d1-dcf9-d1a40712f2b9@intel.com> Date: Wed, 31 Jan 2018 19:11:33 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 19:11:38 -0000 On 1/30/2018 6:06 AM, Andrew Rybchenko wrote: > On 01/29/2018 08:13 PM, Olivier Matz wrote: >> Announce internal PMD API change in the function to set the default MAC >> address. The objective is to be able to notify errors occurring in the >> PMD. >> >> Link: https://dpdk.org/dev/patchwork/patch/32284/ >> >> Signed-off-by: Olivier Matz >> --- >> doc/guides/rel_notes/deprecation.rst | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >> index 43a39d827..8ad4407c2 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -76,3 +76,11 @@ Deprecation Notices >> * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are >> respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old >> names will be removed in v18.08. >> + >> +* ethdev: The prototype and the behavior of >> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code >> + will be added to notify the caller if an error occurred in the PMD. In >> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address >> + will be copied in ``dev->data->mac_addrs[0]`` only if the operation is >> + succesfull. This modification will only impact the PMDs, not the >> + applications. > > Acked-by: Andrew Rybchenko Acked-by: Ferruh Yigit