From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id DB0DC1B472 for ; Wed, 10 Oct 2018 11:06:03 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 910ABB40071; Wed, 10 Oct 2018 09:06:02 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct 2018 10:05:58 +0100 To: Thomas Monjalon CC: , References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> <1539157900-6208-3-git-send-email-arybchenko@solarflare.com> <9285291.oQvEkmlzME@xps> From: Andrew Rybchenko Message-ID: <6dbbefd9-1677-1233-0f7d-0988410b7157@solarflare.com> Date: Wed, 10 Oct 2018 12:05:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <9285291.oQvEkmlzME@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24146.003 X-TM-AS-Result: No-4.870000-8.000000-10 X-TMASE-MatchedRID: pBwXUM+nCwsOwH4pD14DsPHkpkyUphL9FuNF4lJG6xvdeAKnvBMxfPZM gttK6R99WecIUhP2LJGM9QcQn/pjfg+9QmShUWvCc+QhWKJM04M6QNs2WCY79fytJo0tuXDqObT pJWONTOHnzlXMYw4XMMEd1ZAImbby0C1sQRfQzEHEQdG7H66TyJ8TMnmE+d0ZvUH2wUVBwMLtBH p7waD84lkSt4YhVvGjwiUKWgPmDCIx/ECpbzGOJpVkuX8s4TWOh5IMZ+gnxIocO+xoClEFb3YNh yLuFhVJ1DXsKeBNv04EqZlWBkJWd7MZNZFdSWvHG2wlTHLNY1JWXGvUUmKP2w== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.870000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24146.003 X-MDID: 1539162363-NSnrxreWNrFs Subject: Re: [dpdk-dev] [RFC PATCH 2/3] ethdev: advertise default MAC as retained on device restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 09:06:04 -0000 On 10/10/18 11:53 AM, Thomas Monjalon wrote: > 10/10/2018 09:51, Andrew Rybchenko: >> The documentation says MAC addresses array is retained and >> it is logical to assume that default MAC address is retained >> as well. > I'm confused. Default MAC address isn't implied by MAC addresses array? From API point of view it looks as different features (at least for me):  - default MAC address is rte_eth_dev_default_mac_addr_set()  - MAC addresses array is rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove() but it is under one umbrella in NIC features (Unicast MAC filter). May be it is my misunderstanding.