DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
	dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option
Date: Wed, 22 Jul 2020 00:09:52 +0100	[thread overview]
Message-ID: <6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com> (raw)
In-Reply-To: <20200721174712.48625-1-ajit.khaparde@broadcom.com>

On 7/21/2020 6:47 PM, Ajit Khaparde wrote:
> Add an option in meson build to indicate the memory management scheme.
> bnxt_eem_system is set to false by default.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

<...>

> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -2,6 +2,8 @@
>  
>  option('armv8_crypto_dir', type: 'string', value: '',
>  	description: 'path to the armv8_crypto library installation directory')
> +option('bnxt_eem_system', type: 'boolean', value: false,
> +	description: 'EEM system memory support')
>  option('disable_drivers', type: 'string', value: '',
>  	description: 'Comma-separated list of drivers to explicitly disable.')
>  option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
> 

I think it was a design decision to not have all Make config options to meson
build, and reduce compile time configuration as much as possible.

For a while we are pushing back new compile time config options unless they are
really must, the 'RTE_LIBRTE_BNXT_PMD_SYSTEM' has been merged mostly because it
has been missed.

Instead of introducing this PMD level compile time option to meson, can it be
possible to convert the config to runtime config. In the past we have used the
device arguments many times for same reason, can something similar be used here?

  parent reply	other threads:[~2020-07-21 23:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 17:47 Ajit Khaparde
2020-07-21 17:47 ` [dpdk-dev] [PATCH 2/2] doc: update bnxt doc Ajit Khaparde
2020-07-21 23:09 ` Ferruh Yigit [this message]
2020-07-22  0:18   ` [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).