From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A211A04DD; Thu, 22 Oct 2020 11:13:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48DFEA967; Thu, 22 Oct 2020 11:12:47 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id EB871A959 for ; Thu, 22 Oct 2020 11:12:44 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.62]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 77FC560070; Thu, 22 Oct 2020 09:12:43 +0000 (UTC) Received: from us4-mdac16-28.ut7.mdlocal (unknown [10.7.66.60]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 76D7C8009B; Thu, 22 Oct 2020 09:12:43 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.199]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id F05F4280050; Thu, 22 Oct 2020 09:12:42 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5213918005C; Thu, 22 Oct 2020 09:12:41 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Oct 2020 10:12:34 +0100 To: Ferruh Yigit , Ray Kinsella , "Neil Horman" , Hemant Agrawal , Sachin Saxena , Thomas Monjalon CC: , Xiaoyun Li References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> <1603030152-13451-15-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <6e63e0fe-0609-0109-c73e-9ef39e459c82@solarflare.com> Date: Thu, 22 Oct 2020 12:12:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25740.003 X-TM-AS-Result: No-5.236200-8.000000-10 X-TMASE-MatchedRID: u7Yf2n7Ca/3mLzc6AOD8DfHkpkyUphL9/lboZPqaz5VkDFfw8NSG/Hch tJI6MELjAjbDsDYp1Ikt5X33jiiZ27Ud2R7XKvn3boe6sMfg+k+7xmCZDXrutcuaydEXPqkmauP Bry+3W1H5ZsqO5ZgLGThGfZKi00RnfWxSklBAaGl9j6Il8VAHF5sWsKU5yL/GI0YrtQLsSUy1M7 iwCg0ODV890HgjV6tnWv2absn0HUIVcN0zqSS0lNFzvmKugqoCEqfa6mOo3hJGM2uNXRqsUpWMX h7PvokjRbd9W0B+cOPdNv9uTtf3zK3+Px7OO9ohngIgpj8eDcBZDL1gLmoa/NzIddtsV3QreDdY 4UVUBS1YF3qW3Je6+9YeDv3g0Hd5VuZZK7BdJQH3YoN0iLer8m7qj+S3qsT6st9CuXygjbRqyPk DgH7+7V93v6UtrqNw2AV3EiLlQYyXUTWDyN5KXvAdfn5DyOPDXC6uJnc/p0SsglkltB8xdGpozk ualSTDO6clcnPxfVB+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.236200-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25740.003 X-MDID: 1603357963-GlWKCi_baPrX X-PPE-DISP: 1603357963;GlWKCi_baPrX Subject: Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/20/20 5:52 PM, Ferruh Yigit wrote: > On 10/18/2020 3:09 PM, Andrew Rybchenko wrote: >> The legacy filter API, including rte_eth_dev_filter_supported() and >> rte_eth_dev_filter_ctrl() is removed. Flow API should be used. >> >> examples/tep_termination build is broken. >> >> Signed-off-by: Andrew Rybchenko > > <...> > >> --- a/lib/librte_ethdev/rte_eth_ctrl.h >> +++ b/lib/librte_ethdev/rte_eth_ctrl.h >> @@ -43,17 +43,7 @@ enum rte_filter_type { >>    * Generic operations on filters >>    */ >>   enum rte_filter_op { >> -    /** used to check whether the type filter is supported */ >> -    RTE_ETH_FILTER_NOP = 0, >> -    RTE_ETH_FILTER_ADD,      /**< add filter entry */ >> -    RTE_ETH_FILTER_UPDATE,   /**< update filter entry */ >> -    RTE_ETH_FILTER_DELETE,   /**< delete filter entry */ >> -    RTE_ETH_FILTER_FLUSH,    /**< flush all entries */ >> -    RTE_ETH_FILTER_GET,      /**< get filter entry */ >> -    RTE_ETH_FILTER_SET,      /**< configurations */ >> -    RTE_ETH_FILTER_INFO,     /**< retrieve information */ >> -    RTE_ETH_FILTER_STATS,    /**< retrieve statistics */ >> -    RTE_ETH_FILTER_OP_MAX >> +    RTE_ETH_FILTER_GET,      /**< get flow API ops */ >>   }; > > Thanks Andrew working on this, > > It would be nice to have it in -rc1 to be tested better but it was > received late for it. > I suspect there will be more cleanup here or there by time. > > Since there will be a new version, > What do you thinks creating a new dev_ops, like '.flow_ops_get' and > replace '.filter_ctrl' in this patchset? > > This makes the naming/logic more clear, also allows removing a above > 'RTE_ETH_FILTER_GET'. I fully agree, but I'm not sure that I can find time to do it right now. I will move rte_filter_{type,op} enums to ethdev internal interface in v2 and the cleanup could be done any time later.