From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F2CA053A; Tue, 4 Aug 2020 17:38:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7ECFC2BA8; Tue, 4 Aug 2020 17:38:47 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id A39DAF04 for ; Tue, 4 Aug 2020 17:38:45 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from dekelp@mellanox.com) with SMTP; 4 Aug 2020 18:38:42 +0300 Received: from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx [10.228.134.250]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 074FcgnO030522; Tue, 4 Aug 2020 18:38:42 +0300 From: Dekel Peled To: ferruh.yigit@intel.com, arybchenko@solarflare.com, orika@mellanox.com, thomas@monjalon.net Cc: asafp@mellanox.com, matan@mellanox.com, elibr@mellanox.com, dev@dpdk.org Date: Tue, 4 Aug 2020 18:36:20 +0300 Message-Id: <6e8b7c61a92b51749b11ac3bfae5c0201352f9b3.1596550675.git.dekelp@mellanox.com> X-Mailer: git-send-email 1.7.1 Subject: [dpdk-dev] [RFC] ethdev: add VLAN attributes to ETH item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In existing code the match on tagged/untagged packets is not explicit. Recent documentation update [1] describes the different patterns and clarifies the intended use of different patterns. This patch proposes an update to ETH item struct, to clearly define the required characteristic of a packet, and enable precise match criteria. [1] http://mails.dpdk.org/archives/dev/2020-May/166257.html Signed-off-by: Dekel Peled --- lib/librte_ethdev/rte_flow.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index cf0eccb..345feb5 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -726,11 +726,20 @@ struct rte_flow_item_raw { * If the @p ETH item is the only item in the pattern, and the @p type field * is not specified, then both tagged and untagged packets will match the * pattern. + * The fields @p cvlan_exist and @p svlan_exist can be used to match specific + * packet types, instead of using the @p type field. This can be used to match + * on packets that do/don't contain either cvlan, svlan, or both. + * The field @p num_of_vlans can be used to match packets by the exact number + * of VLANs in header. */ struct rte_flow_item_eth { struct rte_ether_addr dst; /**< Destination MAC. */ struct rte_ether_addr src; /**< Source MAC. */ rte_be16_t type; /**< EtherType or TPID. */ + uint32_t cvlan_exist:1; /**< C-tag VLAN exist in header. */ + uint32_t svlan_exist:1; /**< S-tag VLAN exist in header. */ + uint32_t reserved:14; /**< Reserved, must be zero. */ + uint32_t num_of_vlans:16; /**< Number of VLANs in header. */ }; /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */ -- 1.8.3.1