From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [PATCH v2 2/2] net/txgbe: fix debug log
Date: Wed, 23 Feb 2022 14:00:53 +0000 [thread overview]
Message-ID: <6e932425-f978-e5cb-d6d2-2cfdb916acaf@intel.com> (raw)
In-Reply-To: <bcdbcdf2-102f-b02f-7b27-6ae9df5bcf3a@intel.com>
On 2/23/2022 12:49 PM, Ferruh Yigit wrote:
> On 2/23/2022 10:28 AM, Jiawen Wu wrote:
>> Remove 'DEBUGFUNC' due to too many invalid debug log prints, unify the
>> DEBUG level macros.
>>
>> Fixes: 7dc117068a7c ("net/txgbe: support probe and remove")
>> Cc:stable@dpdk.org
>>
>> Signed-off-by: Jiawen Wu<jiawenwu@trustnetic.com>
>> ---
>> drivers/net/txgbe/base/meson.build | 2 +-
>> drivers/net/txgbe/base/txgbe_eeprom.c | 41 ++----
>> drivers/net/txgbe/base/txgbe_hw.c | 202 ++++++--------------------
>> drivers/net/txgbe/base/txgbe_mbx.c | 38 -----
>> drivers/net/txgbe/base/txgbe_mng.c | 21 +--
>> drivers/net/txgbe/base/txgbe_osdep.h | 1 +
>> drivers/net/txgbe/base/txgbe_phy.c | 84 ++---------
>> drivers/net/txgbe/base/txgbe_vf.c | 12 +-
>> drivers/net/txgbe/txgbe_logs.h | 7 +-
>> 9 files changed, 79 insertions(+), 329 deletions(-)
>>
>> diff --git a/drivers/net/txgbe/base/meson.build b/drivers/net/txgbe/base/meson.build
>> index 7a30191472..09da79af40 100644
>> --- a/drivers/net/txgbe/base/meson.build
>> +++ b/drivers/net/txgbe/base/meson.build
>> @@ -22,6 +22,6 @@ foreach flag: error_cflags
>> endforeach
>> base_lib = static_library('txgbe_base', sources,
>> - dependencies: static_rte_eal,
>> + dependencies: [static_rte_eal, static_rte_ethdev],
>
> Is this because of 'RTE_ETHER_ADDR_PRT_FMT' macro?
> If so dependency should be 'static_rte_net', not ethdev.
fixed in next-net while merging.
next prev parent reply other threads:[~2022-02-23 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 10:28 [PATCH v2 0/2] Wangxun log fixes Jiawen Wu
2022-02-23 10:28 ` [PATCH v2 1/2] net/ngbe: fix debug log Jiawen Wu
2022-02-23 10:28 ` [PATCH v2 2/2] net/txgbe: " Jiawen Wu
2022-02-23 12:49 ` Ferruh Yigit
2022-02-23 14:00 ` Ferruh Yigit [this message]
2022-02-23 14:01 ` [PATCH v2 0/2] Wangxun log fixes Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e932425-f978-e5cb-d6d2-2cfdb916acaf@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).