Re: [dpdk-dev] [PATCH] net/virtio: allocate vrings on device NUMA node

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 11/27/18 2:29 PM, David Marchand wrote:
> On Tue, Nov 27, 2018 at 11:54 AM Maxime Coquelin 
> <maxime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:
> 
>     When a guest is spanned on multiple NUMA nodes and
>     multiple Virtio devices are spanned onto these nodes,
>     we expect that their ring memory is allocated in the
>     right memory node.
> 
>     Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com
>     <mailto:maxime.coquelin@redhat.com>>
>     ---
>       drivers/net/virtio/virtio_ethdev.c | 12 +++++++-----
>       1 file changed, 7 insertions(+), 5 deletions(-)
> 
>     diff --git a/drivers/net/virtio/virtio_ethdev.c
>     b/drivers/net/virtio/virtio_ethdev.c
>     index 2ba66d291..d99571d93 100644
>     --- a/drivers/net/virtio/virtio_ethdev.c
>     +++ b/drivers/net/virtio/virtio_ethdev.c
>     @@ -335,8 +335,10 @@ virtio_init_queue(struct rte_eth_dev *dev,
>     uint16_t vtpci_queue_idx)
>              void *sw_ring = NULL;
>              int queue_type = virtio_get_queue_type(hw, vtpci_queue_idx);
>              int ret;
>     +       int numa_node = dev->device->numa_node;
> 
>     -       PMD_INIT_LOG(DEBUG, "setting up queue: %u", vtpci_queue_idx);
>     +       PMD_INIT_LOG(INFO, "setting up queue: %u on NUMA node %u",
> 
> 
> %d ?

Right, thanks for spotting it.

Maxime