From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 7BBEF47CE;
 Tue, 27 Nov 2018 15:28:00 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 9647B80E7B;
 Tue, 27 Nov 2018 14:27:59 +0000 (UTC)
Received: from [10.36.112.53] (ovpn-112-53.ams2.redhat.com [10.36.112.53])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 16395608C1;
 Tue, 27 Nov 2018 14:27:50 +0000 (UTC)
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
 jfreimann@redhat.com, stable@dpdk.org
References: <20181127105427.11641-1-maxime.coquelin@redhat.com>
 <CAJFAV8y=cpLH4YQo1p1hS-JM5WVarSbD4T95T0MbgnXHNbB9Vw@mail.gmail.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <6e99a49c-7213-7d7a-308e-e32fe5106bee@redhat.com>
Date: Tue, 27 Nov 2018 15:27:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8y=cpLH4YQo1p1hS-JM5WVarSbD4T95T0MbgnXHNbB9Vw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.25]); Tue, 27 Nov 2018 14:27:59 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] net/virtio: allocate vrings on device NUMA
 node
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Nov 2018 14:28:01 -0000



On 11/27/18 2:29 PM, David Marchand wrote:
> On Tue, Nov 27, 2018 at 11:54 AM Maxime Coquelin 
> <maxime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:
> 
>     When a guest is spanned on multiple NUMA nodes and
>     multiple Virtio devices are spanned onto these nodes,
>     we expect that their ring memory is allocated in the
>     right memory node.
> 
>     Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com
>     <mailto:maxime.coquelin@redhat.com>>
>     ---
>       drivers/net/virtio/virtio_ethdev.c | 12 +++++++-----
>       1 file changed, 7 insertions(+), 5 deletions(-)
> 
>     diff --git a/drivers/net/virtio/virtio_ethdev.c
>     b/drivers/net/virtio/virtio_ethdev.c
>     index 2ba66d291..d99571d93 100644
>     --- a/drivers/net/virtio/virtio_ethdev.c
>     +++ b/drivers/net/virtio/virtio_ethdev.c
>     @@ -335,8 +335,10 @@ virtio_init_queue(struct rte_eth_dev *dev,
>     uint16_t vtpci_queue_idx)
>              void *sw_ring = NULL;
>              int queue_type = virtio_get_queue_type(hw, vtpci_queue_idx);
>              int ret;
>     +       int numa_node = dev->device->numa_node;
> 
>     -       PMD_INIT_LOG(DEBUG, "setting up queue: %u", vtpci_queue_idx);
>     +       PMD_INIT_LOG(INFO, "setting up queue: %u on NUMA node %u",
> 
> 
> %d ?

Right, thanks for spotting it.

Maxime