From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA8C0A0546; Fri, 14 Feb 2020 08:46:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 230DF1BE80; Fri, 14 Feb 2020 08:46:24 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id F2C761BC25 for ; Fri, 14 Feb 2020 08:46:21 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id g6so3421368plp.6 for ; Thu, 13 Feb 2020 23:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Oiu1ny2SPKccoO3bwwrXy+COcM8pPhN4n9o4KM6R4r0=; b=hP+AD6aNBEJakaj5doBElGv94joF0UoUMqtvkIn+3is4yDBsBbjkhJdlxnhpcHA06i 5gBLVRNKdm71+t2Tnig/0v2hxyc4wPi5odKnaUb0nLAeID0StYt3gGW4fBdtrpY0fpjj 8jKAQ4H8UDnG00iMyqvpPH99RCfzYVRJFMC/pNkJN9sLeIEZlLc0SIke5j1B6Q53/Rnn 1Z4EHuRwiq/fVcj+cw4A4hoCq21pqFNO30iIS/zG60lX4rMBzBoz/LmJkvEsCFHbmKFY BunNzW65m16swcgrdp2JP/tHX1k8RWwi8DG5XNZnpNAYKMqMmoFD+pEPE3McqRqIQyTp szcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Oiu1ny2SPKccoO3bwwrXy+COcM8pPhN4n9o4KM6R4r0=; b=s7IAT1BFPhhqp/ZzMXPW7ZdOL1kuL0bLgsPyt55R70kNZq1cMAEfTVk3hewjjvSiSk Y7ZHIoS0dwjcxDGXlUmWqkLiXNUKV00Sv48z95MG+CHBA8cc/Te+CHP+VQcGbjTFDjdz 8p4ShBXHKUr2iySyuEHd+w9izIidToXXW40QTK7aqBH8BwNLSMjsPitJMNsu0dOYqMKg ZztSqpcSvyOGayRJxtZLKcEwqrqiaZGp84GuhrU9p495rZku5ZsxYQqMFrbtUWWFqZd7 0qMm0Yf1RvCZQ/ge3EbNeZvVgmf4i7o3gQjrnEmDMjTFBtqthTi9Pw6lsrFMHriuiOFf dJ3Q== X-Gm-Message-State: APjAAAUUudzDomWcBx8bjFx0WoeEaxeboZ8TGv+/CfJwv6f/dfDsk24R EeHR4iV+oCyVmIr8pSH6esc= X-Google-Smtp-Source: APXvYqyKAYX4T+q/1yGTxkFp3sg1AnuPurnYWTrHxh6psSknZLBBIejy+nBq5TRTOex3QksmwvXRrA== X-Received: by 2002:a17:902:426:: with SMTP id 35mr2033369ple.302.1581666381027; Thu, 13 Feb 2020 23:46:21 -0800 (PST) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id c10sm5631867pgj.49.2020.02.13.23.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2020 23:46:20 -0800 (PST) To: "Burakov, Anatoly" , konstantin.ananyev@intel.com, david.marchand@redhat.com, dev@dpdk.org Cc: yasufumi.ogawa.gy@hco.ntt.co.jp, Yasufumi Ogawa References: <20191113214346.33749-1-yasufum.o@gmail.com> <20191127084826.3519-1-yasufum.o@gmail.com> <20191127084826.3519-2-yasufum.o@gmail.com> <2dc8c11a-ec17-7b26-b79e-bed4e6063f6b@intel.com> From: Yasufumi Ogawa Message-ID: <6ea0b73a-1d38-dbe1-2142-9ab4fec594e7@gmail.com> Date: Fri, 14 Feb 2020 16:46:15 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <2dc8c11a-ec17-7b26-b79e-bed4e6063f6b@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Could I confirm that this patch is going to be merged in 20.02? Regards, Yasufumi On 2019/12/06 19:44, Burakov, Anatoly wrote: > On 27-Nov-19 8:48 AM, Yasufumi Ogawa wrote: >> From: Yasufumi Ogawa >> >> In secondary_msl_create_walk(), it creates a file for fbarrays with its >> PID for reserving unique name among secondary processes. However, it >> does not work if several secondaries run as app containers because each >> of containerized secondary has PID 1, and failed to reserve unique name >> other than first one. To reserve unique name in each of containers, use >> hostname in addition to PID. >> >> Signed-off-by: Yasufumi Ogawa >> --- >>   lib/librte_eal/common/include/rte_fbarray.h |  7 ++++++- >>   lib/librte_eal/linux/eal/eal_memalloc.c     | 11 ++++++++--- >>   2 files changed, 14 insertions(+), 4 deletions(-) >> >> diff --git a/lib/librte_eal/common/include/rte_fbarray.h >> b/lib/librte_eal/common/include/rte_fbarray.h >> index 6dccdbec9..df003b8dc 100644 >> --- a/lib/librte_eal/common/include/rte_fbarray.h >> +++ b/lib/librte_eal/common/include/rte_fbarray.h >> @@ -39,7 +39,12 @@ extern "C" { >>   #include >>   #include >> -#define RTE_FBARRAY_NAME_LEN 64 >> +/* Filename of fbarray is defined as a combination of several params >> + * such as "fbarray_memseg-1048576k-0-0_PID_HOSTNAME". >> + * The length of string before PID can be 32bytes, and the length of >> + * PID can be 7bytes maximamly. Final 1 byte is for null terminator. >> + */ >> +#define RTE_FBARRAY_NAME_LEN (32 + 7 + 1 + HOST_NAME_MAX + 1) > > This breaks ABI, but i believe this doesn't break *stable* ABI, so it is > OK. > > Reviewed-by: Anatoly Burakov >