From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06DD142D8B; Thu, 29 Jun 2023 13:08:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB508427EE; Thu, 29 Jun 2023 13:08:29 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by mails.dpdk.org (Postfix) with ESMTP id E568F406B7 for <dev@dpdk.org>; Thu, 29 Jun 2023 13:08:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGPHHMrUI1B4QhwV/m072rAyUbXVTVOMLpN0lSkit75+gOZzRTsHUuQPGB6n3quRJWYn7jTAUINoRKN0iE0SfttrVO4SDfPHBrR3ALlgicNcNUG3Lb0maPfEcHQHN3qFnKDFA0LNIN8Md6KCNJS9zWgPwJkfBFWdMya7DnwlEC/cwZnCW9DQTbUKJeOmItS/FfRLtQZH0btpjC2f/WeKs/U+PSNpmrqOYhNv+iNNnxv7OJskH2zcL2HP6CvQe3mUMyUN3rvovguUGWbcThIHsmFt2sh2w3ATGA4Q32hDWPRGpTZ+tfsTX+/AYnDH9vJng7q+PsawPmXpRkxDtKmP4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zfdougqLZU16DmzowjfEPr8J5Gzph7T6rvFeOCMF1Gg=; b=MtC3xL1Ikz3iJAbs5aXuL0qmP/CpG4vO8QQTGeLYriBh+1fES2hpJCd5CB1Fqr+B6LNwuwy4UqvbVEop/IfpeCG2VjZdcAGyi4S/F9jwXWhPiqR/UZkCjBtiW2Lqr+GMpdGVrckg57EtBD0zIHCcwvBQSc2LVp+ragtpDJXkIwGN0mJmteTpXAWelX/dBUxnwvYJrpY+/0/qGDwmYy7oYCiDtTuYU3MgW1jv9OMO3bAp4t95dgyqa+gzb+5B9E2BivO6YZsoASAySFOn/Uo6qN/0LYSfu2/Kxz+/ob94YsEQzfyNOqTs2jtyVMa935InVYvqi5J9RoJNH4DZ7jomTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zfdougqLZU16DmzowjfEPr8J5Gzph7T6rvFeOCMF1Gg=; b=Grv6oXwF1C7N05JbkTSCekRpGXAcpx73Efmz6vebx/dLJcDxn1/MiLd9BasiHu+H7OUkr+R7kjlcPuDdrtIxkI5QYrTv22JFVIkZaQ9Nk4UxU2qj2PBcYuGMJBXs82sUPXjhyDv8XH7BIyAISXxA4f8srVV9cKAtovshXHkx9Bk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN0PR12MB6367.namprd12.prod.outlook.com (2603:10b6:208:3d3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Thu, 29 Jun 2023 11:08:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Thu, 29 Jun 2023 11:08:25 +0000 Message-ID: <6eb5db93-816b-5a4d-0239-0593479c9501@amd.com> Date: Thu, 29 Jun 2023 12:08:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config Content-Language: en-US To: Dongdong Liu <liudongdong3@huawei.com>, Thomas Monjalon <thomas@monjalon.net>, lihuisong@huawei.com Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru References: <20230626124332.28157-1-liudongdong3@huawei.com> <20230627071126.17161-1-liudongdong3@huawei.com> <20230627071126.17161-3-liudongdong3@huawei.com> <16389153.hlxOUv9cDv@thomas> <36dea9f8-2f7d-6efe-b61d-d4ca393bf777@huawei.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <36dea9f8-2f7d-6efe-b61d-d4ca393bf777@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0122.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN0PR12MB6367:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a9b5f33-f5d3-44d9-8009-08db789128b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3JlMD8KnU5c50EDhI1fsHF34/mgBo9zR0Hai18KJ69FIqFab4qCHodsIQMsXiQkbWuiCnvdcjgxayh+cgmTT557hXWGpxpdChq//2mdgs5VuR6pYZZ45Q/+zj2wH8lPYRhl3rifb/GVcAx9VEWBfPi2amcrXGgCf8a+b1o3/QUUU8P/zwGv2kK+8LBAY7tJKVdcN/Z3VBVaxHBwRTls5TFHtoZ1hN78sKT31GOgdzdcGJOfyyVOkoNTeEJMg9VDTLwA4bRSAaG/72rLLyQGS5z6w78msTcp805eelu7c7S3ZcjGASdhYTU16sN5joPhUSQzW+ZSRZLtBh7OE4JGBKdlYgS38/tbVmngSHbqGiBxIvpQNSq2aEO+BorG8n4g2t0gsU6RvDiA0fGBor/eprMWKFyJMqRxBwtUk8pix4XB6ZnTvJg8qbi+1l77kD9QzvtQ4Bipcjswk72HDlYNzFZzPC5DtgJ3NAk2gl8tXVn5a2nF8RGZnqCU9XtZ7ZYGE75o8fuSKY8mAwy551NrZS7HhHdJlTzKO3ITBpWOtamS5ObgpVkDAjH5gO5E4mqOkk+fEjitb+duhHJneL9l4qDFvUoyQzdCCNnojnW40waBVgI8GZ/MPPIB/Dq56uhYUQCRMJnZkYFU2xBG7xqKtzw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(83380400001)(110136005)(6666004)(478600001)(6486002)(53546011)(2906002)(66946007)(186003)(26005)(66476007)(6506007)(66556008)(6512007)(5660300002)(316002)(44832011)(41300700001)(38100700002)(8676002)(8936002)(36756003)(4326008)(31696002)(86362001)(2616005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXJCcjJRQmxtdTQrRldEcVJIbDI3SXY4STBYM0FyMjZ4TGI1YjFPYmFrV3E1?= =?utf-8?B?Z3pmS21hSGdjYjlwSnBWRjZXalJUYWYyR0JPZjVoK2VCcCsvSURKNVQ4SGpL?= =?utf-8?B?VjVQSGpZaFRia0t4N055YW54eHNnNCs1UEJITStWZ2EycTUyL2svTHF2akQv?= =?utf-8?B?TjY2dUNqNWN0dElwekZQZkRxU29zcTI5VFMzamJZelpXejA5Ky9sdGZBUENO?= =?utf-8?B?TDBjUlRXMnlVRHVZSzU3cXg3Z05YdWdJN20yT3plbE5KTm9XR08zREpGSmUr?= =?utf-8?B?eG0zQndXUWJ0YWJVMkk4dGp4Vmg1M2lmSURnRitNQnNaL1BQWEhVZHhyUzhE?= =?utf-8?B?VUVtT2s5RGNSb3lBQWZtSGJkZm5QK0pmSVQrL2hPVXV3UUNPUitBZjZCK2JM?= =?utf-8?B?OS8xL0pIVzdaK1hLM25lTG5MTTF0OURwbHRrTVBEZ3IydmNTdWlUZjc1Yzds?= =?utf-8?B?QWtqaFdodG8zenN1WXdwN09CUXlPQUFPWDc5WWRhaHZBWnMrUW1kblZHdUVy?= =?utf-8?B?MUV5endGS2Q0R1JwcCtvbElvUTJmUThQVURHVWg1MGk4TW1tcVJNS2ExZUlS?= =?utf-8?B?WW5sNXpxOW9VSkNkZFVVT3ExR1VIRkRCdGhmdThpU3dHZVEvTFZncm5ENHJv?= =?utf-8?B?M1BtOFBQS1B3Sk9yMzhNUlZRVDZCTkg5R08zNitwcFg5TTlLVUZwLzVaYnRB?= =?utf-8?B?WWZOUElhUk12dThoTzFyM0JoSXBacVZBU2MvMFZlQTFDaEFYU0Q1STJ2Tjl0?= =?utf-8?B?RDkzMVdnVk9hT1d6QlFHNzYxZ0Q0cFNkQWI5OVlUdXFBQU9uZ3lTTHc2RDIy?= =?utf-8?B?V0UxYTFvZFFIYmp1SFJZRFZrTGFHU21Ralo0bk4yS2QvblJ6Zyt2Z2FUMzFW?= =?utf-8?B?SmJQbzR3RXdVNWt4NFVVT2xMU0ZLcFJ2WE41Sjc5KzVFSEhvUGJwMGk0TlBa?= =?utf-8?B?S1hQZXp4RmtvVGZ2QzBIT3ZtMzVxYzhhL0hTaVRaLy9FRTJpOUhTMXRWYXho?= =?utf-8?B?OStmZ0FWa3VuR1dYMG0yaFE2Qy9uSi8yU2VWRkNRcWhoVGdENTF4bWdZeC9w?= =?utf-8?B?SURxT0k4MU1lN2grdytGR2dWRkVJMXp3L2FTQ3NXdkdRRGRqN2xQRmV4LzNw?= =?utf-8?B?QjdTSGNJRHVGaHQwT2VVS0YwZ1FtNDFKZTJkOHRtbERmTVZPQ1hyL0ljVUlk?= =?utf-8?B?V2xoK2VRUzdLM2pmc1hFWmo5WTVKOTdoeElTaUdibmwwRWVsWmpobE1XRFV3?= =?utf-8?B?OXJCNWpoeGVBcFJJNHBUdUdtZUpGL0JTWWhZNVNWWFJVNjhqaVdPaGIyMm1n?= =?utf-8?B?UXNpaTh3THl1eEJQSDA5QTMyT0x3aWNlYXhxeUZQamZ3RU5MOE5iVVMvSlk5?= =?utf-8?B?YVR4VGs5VXpDekNRejFURWZoN0wxUHk3dmU3c21kVW1SVVcyWXpnTDVlWGNa?= =?utf-8?B?bVNiajR0OHM4STU4LzM1NUs1T1Jsc2NEZUV6bjRicG9VYmd3c3JsWTVxVnMy?= =?utf-8?B?SSs2cFRpT0JhQXpNY05SbkhINkViYlJ6SlZUVVpjSzdlYVdGRDh1U1FTU2Js?= =?utf-8?B?emtrYXpzSjJ6OFUyZnMwNWE0amU0ZXJGeXE0bS84Ujg2WHp4M1JxVG80K204?= =?utf-8?B?Q2kwRzVPcTRnTDkxeDZEYU4vNXRxcnJPdXFzZ0NPckhRb2lmQVBLODRsSitZ?= =?utf-8?B?MGZqUVE5OW5taDJhTEpRNS8xVDJMVnBDSnRLZUYxdWI0bHQzMHhTZDU5Q3dl?= =?utf-8?B?akpyY3hrcnZwc1JPT0QzN25QRG1CcVljUVcvbzJZQVlGcVZCbUFQOE1IZEF6?= =?utf-8?B?ZHZCck1Ecjl1YnlJNXdDaUFlUU9aVDRpdUYvU0FzZnVGa0pXQjVkaytqR2x3?= =?utf-8?B?V2lNZEdaTVI1OTREb1UwOWEyRklzRVFhY0hIUFJSR1IvVFpsbHk4bmVOWENY?= =?utf-8?B?MDVuWGY5RXhtYlhHeXllNS9vaGZzMTRQWVVtNVU3RWxXNDBUN24rYlNPV055?= =?utf-8?B?OUpHWllFemthQjFESzZJSXJCY2tiSEdxR0l2R29tQmFOS2orVWdJVXBVWTRk?= =?utf-8?B?ZjM3aDRFeC9TSTZqbTJUdU1lUjB0eWxHejhPbUVoZHkxN2IxQUUxUWtoQ2I5?= =?utf-8?Q?7dCCuktDlm+L7hzd5svU2CaUo?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a9b5f33-f5d3-44d9-8009-08db789128b3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 11:08:25.3652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t1A7THH0ZHzvrT4gMkm778lu9pL484eB28RmAwKyYJXDFoKe2BEBrjfWIQS/CKzr X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6367 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 6/28/2023 3:59 AM, Dongdong Liu wrote: > Hi Thomas > > Many thanks for your review. > > On 2023/6/28 7:12, Thomas Monjalon wrote: >> 27/06/2023 09:11, Dongdong Liu: >>> +- ``fdir_vlan_match_mode`` (default `strict`) >>> + >>> + Used to select VLAN match mode. This runtime config can be `strict` >>> + or `nostrict` and is only valid for PF drives. >> >> drives? Do you mean devices? > for PF devices, will fix. >> >>> + If driver works on `strict` mode (default mode), hardware does >>> strictly >>> + match the input flow base on VLAN number. >>> + >>> + For the following scenarios with two rules: >>> + >>> + .. code-block:: console >>> + >>> + rule0: >>> + pattern: eth type is 0x0806 >>> + actions: queue index 3 >>> + rule1: >>> + pattern: eth type is 0x0806 / vlan vid is 20 >>> + actions: queue index 4 >>> + >>> + If application select `strict` mode, only the ARP packets with VLAN >>> + 20 are directed to queue 4, and the ARP packets with other VLAN ID >>> + cannot be directed to the specified queue. If application want to all >>> + ARP packets with or without VLAN to be directed to the specified >>> queue, >>> + application can select `nostrict` mode and just need to set rule0. >> >> As it is done in the rest of the document, you should use double >> backquotes >> for values of the devargs. > Good point, will fix. > I dropped set from next-net, please send a new version with fix. Updating patchwork status as "Change Requested".