From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F82FA00C4; Sun, 6 Nov 2022 11:02:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3883D40691; Sun, 6 Nov 2022 11:02:40 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A3A884003C for ; Sun, 6 Nov 2022 11:02:38 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1A90662; Sun, 6 Nov 2022 13:02:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1A90662 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667728958; bh=foKCLts+7f2AcOra4WssjwCGalohpAJptaHf716zmKg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=COlx14ZAjm7a/Yk8jSaOpfNH803vFmpAMNxPb5EkiyFMArNB/aFDH6Syb+FZ+RCA4 iCoJbs+wrzT+P8BodTLYfLGCTW4xUT1a3pCgtpoonJB4gkNqQSaWs64r4OYD8JFkui X1FFSR9OiX1aGYCAxcakp7jmzNqjvr+8oCgOHCfQ= Message-ID: <6ec3f733-6370-d90f-b6b6-3eaceec7d0b2@oktetlabs.ru> Date: Sun, 6 Nov 2022 13:02:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3] ethdev: add hint when creating async transfer table Content-Language: en-US From: Andrew Rybchenko To: Rongwei Liu , matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net, Aman Singh , Yuying Zhang , Ferruh Yigit Cc: dev@dpdk.org, rasland@nvidia.com References: <5d8d42b2-7011-cb46-7f2c-1b1019c4151e@oktetlabs.ru> <20220928092425.68214-1-rongweil@nvidia.com> Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/4/22 11:31, Andrew Rybchenko wrote: > On 9/28/22 12:24, Rongwei Liu wrote: >> The transfer domain rule is able to match traffic wire/vf >> origin and it means two directions' underlayer resource. >> >> In customer deployments, they usually match only one direction >> traffic in single flow table: either from wire or from vf. >> >> Introduce one new member transfer_mode into rte_flow_template_table_attr >> to indicate the flow table direction property: from wire, from vf >> or bi-direction(default). >> >> It helps to save underlayer memory also on insertion rate, and this >> new field doesn't expose any matching criteira. >> >> By default, the transfer domain is to match bi-direction traffic, and >> no behavior changed. >> >> 1. Match wire origin only >>     flow template_table 0 create group 0 priority 0 transfer wire_orig... >> 2. Match vf origin only >>     flow template_table 0 create group 0 priority 0 transfer vf_orig... > > Since wire_orig and vf_orig are just optional hints and not > all PMDs are obliged to handle it, it does not impose any > matching criteria. So, example above are misleading and you > need to add pattern items to highlight that corresponding rules > are really wire_orig or vf_orig. I'm sorry, but I still don't see how it is addressed in v4. > >> >> Signed-off-by: Rongwei Liu >> Acked-by: Ori Kam > > [snip] >