From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB27CA0A0A; Thu, 3 Jun 2021 09:14:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7513640689; Thu, 3 Jun 2021 09:14:33 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A58654067A for ; Thu, 3 Jun 2021 09:14:31 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3CE017F4F8; Thu, 3 Jun 2021 10:14:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3CE017F4F8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1622704471; bh=BDVHWY4oEwEpkCNqZ+0xo9jzSdJ03fDpta8Ece/cqGs=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=bY2zDxBn4J5VUeiEeHQtEu2cFiJk/i7d2lxsSi/oYLNgY4pU2tyjAiVnBwYtwPvqp V0aYsMrc/5hI4sy3mdcj7ifh5CX/fh0sFJUgbGji1YVGJc6CIrb8zbGEX680Snl4l0 jnszKsNxFZ5eGaPZRam8hPjxeFDdDa6c6ZXRf2FU= To: Alvin Zhang , ferruh.yigit@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org References: <20210603031214.19892-1-alvinx.zhang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <6f08cf7b-6ba0-f678-f7f0-5b5a39dd0de3@oktetlabs.ru> Date: Thu, 3 Jun 2021 10:14:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210603031214.19892-1-alvinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: add RSS offload type for L3 checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/3/21 6:12 AM, Alvin Zhang wrote: > Add ETH_RSS_L3_CHKSUM macro. Sorry, too short description. I could be an existing practice to add more RSS offload types, but I want to break it. Please, add motivation in the description why it is useful etc. > > Signed-off-by: Alvin Zhang > --- > lib/ethdev/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index faf3bd9..4220ec5 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -537,6 +537,7 @@ struct rte_eth_rss_conf { > #define ETH_RSS_PPPOE (1ULL << 31) > #define ETH_RSS_ECPRI (1ULL << 32) > #define ETH_RSS_MPLS (1ULL << 33) Please, add a comment what does it mean in various cases covering various L3 protocols. IMHO, we must be explicit here since addition of a new L3 protocol will make it ambiguous if some drivers/HW use its checksum, but some do not. > +#define ETH_RSS_L3_CHKSUM (1ULL << 34) > > /* > * We use the following macros to combine with above ETH_RSS_* for >