From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 64762D4A4 for ; Tue, 7 Feb 2017 14:48:12 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 07 Feb 2017 05:48:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="818053550" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2017 05:48:09 -0800 To: Jingjing Wu , dev@dpdk.org References: <1486179375-133509-1-git-send-email-jingjing.wu@intel.com> <1486437727-83972-1-git-send-email-jingjing.wu@intel.com> <1486437727-83972-2-git-send-email-jingjing.wu@intel.com> Cc: olivier.matz@6wind.com, helin.zhang@intel.com, konstantin.ananyev@intel.com From: Ferruh Yigit Message-ID: <6f19a12e-8768-a8a1-52b0-9cdcba20fbc7@intel.com> Date: Tue, 7 Feb 2017 13:48:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1486437727-83972-2-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/4] net/i40e: fix bitmask of supported Tx flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 13:48:12 -0000 On 2/7/2017 3:22 AM, Jingjing Wu wrote: > PKT_TX_TUNNEL_MASK and PKT_TX_IEEE1588_TMST are missed in bitmask > of all supported packet Tx flags by i40e. It will cause packet preparing > fail when sending tunnel packets with Tx offload. > This patch fixes it. > > Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/i40e_rxtx.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c > index 608685f..48429cc 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -75,6 +75,12 @@ > > #define I40E_TXD_CMD (I40E_TX_DESC_CMD_EOP | I40E_TX_DESC_CMD_RS) > > +#ifdef RTE_LIBRTE_IEEE1588 > +#define I40E_TX_IEEE1588_TMST PKT_TX_IEEE1588_TMST > +#else > +#define I40E_TX_IEEE1588_TMST 0 > +#endif > + > #define I40E_TX_CKSUM_OFFLOAD_MASK ( \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ > @@ -87,7 +93,9 @@ > PKT_TX_OUTER_IP_CKSUM | \ > PKT_TX_TCP_SEG | \ > PKT_TX_QINQ_PKT | \ > - PKT_TX_VLAN_PKT) > + PKT_TX_VLAN_PKT | \ > + PKT_TX_TUNNEL_MASK | \ > + I40E_TX_IEEE1588_TMST) PKT_TX_IEEE1588_TMST added into I40E_TX_OFFLOAD_MASK, but not into PKT_TX_OFFLOAD_MASK (patch 4/4) Shouldn't PKT_TX_OFFLOAD_MASK be a super set of driver ones. Otherwise PKT_TX_IEEE1588_TMST will be marked as not supported according below XOR logic. > > #define I40E_TX_OFFLOAD_NOTSUP_MASK \ > (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK) >