* [dpdk-dev] [PATCH] net/enic: fix CRC strip offload capability
@ 2018-05-14 7:56 Hyong Youb Kim
2018-05-14 10:50 ` Hyong Youb Kim
0 siblings, 1 reply; 3+ messages in thread
From: Hyong Youb Kim @ 2018-05-14 7:56 UTC (permalink / raw)
To: dev, ferruh.yigit; +Cc: johndale, Hyong Youb Kim
The NIC always strips CRC, so advertise the CRC strip offload in
rx_offload_capa.
Fixes: 93fb21fdbe23 ("net/enic: enable overlay offload for VXLAN and GENEVE")
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
---
drivers/net/enic/enic_res.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
index a504de5d5..fc60d8b77 100644
--- a/drivers/net/enic/enic_res.c
+++ b/drivers/net/enic/enic_res.c
@@ -188,6 +188,7 @@ int enic_get_vnic_config(struct enic *enic)
DEV_TX_OFFLOAD_TCP_CKSUM |
DEV_TX_OFFLOAD_TCP_TSO;
enic->rx_offload_capa =
+ DEV_RX_OFFLOAD_CRC_STRIP |
DEV_RX_OFFLOAD_VLAN_STRIP |
DEV_RX_OFFLOAD_IPV4_CKSUM |
DEV_RX_OFFLOAD_UDP_CKSUM |
--
2.16.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: fix CRC strip offload capability
2018-05-14 7:56 [dpdk-dev] [PATCH] net/enic: fix CRC strip offload capability Hyong Youb Kim
@ 2018-05-14 10:50 ` Hyong Youb Kim
2018-05-14 11:02 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Hyong Youb Kim @ 2018-05-14 10:50 UTC (permalink / raw)
To: dev, ferruh.yigit; +Cc: johndale
On Mon, May 14, 2018 at 12:56:20AM -0700, Hyong Youb Kim wrote:
> The NIC always strips CRC, so advertise the CRC strip offload in
> rx_offload_capa.
Hi Ferruh,
Can you discard this patch? We are finding more offload flags are
missing. Will submit a new patch that sets them all instead of one patch
per flag. Sorry for the trouble.
Thanks..
-Hyong
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: fix CRC strip offload capability
2018-05-14 10:50 ` Hyong Youb Kim
@ 2018-05-14 11:02 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-14 11:02 UTC (permalink / raw)
To: Hyong Youb Kim, dev; +Cc: johndale
On 5/14/2018 11:50 AM, Hyong Youb Kim wrote:
> On Mon, May 14, 2018 at 12:56:20AM -0700, Hyong Youb Kim wrote:
>> The NIC always strips CRC, so advertise the CRC strip offload in
>> rx_offload_capa.
>
> Hi Ferruh,
>
> Can you discard this patch? We are finding more offload flags are
> missing. Will submit a new patch that sets them all instead of one patch
> per flag.
OK, please provide new version.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-14 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 7:56 [dpdk-dev] [PATCH] net/enic: fix CRC strip offload capability Hyong Youb Kim
2018-05-14 10:50 ` Hyong Youb Kim
2018-05-14 11:02 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).