DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse
Date: Tue, 15 May 2018 13:16:52 +0100	[thread overview]
Message-ID: <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com> (raw)
In-Reply-To: <d986a385-0854-7a70-2323-4dc8b8a3c4eb@solarflare.com>

On 15-May-18 12:36 PM, Andrew Rybchenko wrote:
> On 05/15/2018 01:44 PM, Anatoly Burakov wrote:
>> The intention of the original code was to create runtime data
>> directory as early as possible, however it was moved too early,
>> before the arguments were parsed, resulting in --file-prefix
>> option essentially not working.
>>
>> Fix this by moving eal_create_runtime_dir() to after command
>> line arguments parsing.
>>
>> Fixes: 56236363b481 ("eal: add directory for runtime data")
>>
>> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> I've tested it quickly and it solves the problem I observe.
> I suppose it is OK that the directory remains after application exit.
> 

Previously, all of the files that we were creating during runtime 
remained, so having a directory where all the files are is better than 
having a scattering of files :)

Thanks for testing!

-- 
Thanks,
Anatoly

  reply	other threads:[~2018-05-15 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 10:44 Anatoly Burakov
2018-05-15 11:36 ` Andrew Rybchenko
2018-05-15 12:16   ` Burakov, Anatoly [this message]
2018-05-15 14:03     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).