From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 396121B783 for ; Tue, 15 May 2018 14:16:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2018 05:16:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,403,1520924400"; d="scan'208";a="40050719" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.6.248]) ([10.252.6.248]) by fmsmga008.fm.intel.com with ESMTP; 15 May 2018 05:16:56 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Bruce Richardson , thomas@monjalon.net References: From: "Burakov, Anatoly" Message-ID: <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com> Date: Tue, 15 May 2018 13:16:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 12:17:00 -0000 On 15-May-18 12:36 PM, Andrew Rybchenko wrote: > On 05/15/2018 01:44 PM, Anatoly Burakov wrote: >> The intention of the original code was to create runtime data >> directory as early as possible, however it was moved too early, >> before the arguments were parsed, resulting in --file-prefix >> option essentially not working. >> >> Fix this by moving eal_create_runtime_dir() to after command >> line arguments parsing. >> >> Fixes: 56236363b481 ("eal: add directory for runtime data") >> >> Reported-by: Andrew Rybchenko >> >> Signed-off-by: Anatoly Burakov > > Tested-by: Andrew Rybchenko > > I've tested it quickly and it solves the problem I observe. > I suppose it is OK that the directory remains after application exit. > Previously, all of the files that we were creating during runtime remained, so having a directory where all the files are is better than having a scattering of files :) Thanks for testing! -- Thanks, Anatoly