From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BB06A034E; Mon, 14 Feb 2022 17:53:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D1FF41153; Mon, 14 Feb 2022 17:53:31 +0100 (CET) Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by mails.dpdk.org (Postfix) with ESMTP id 0CB9B4067E for ; Mon, 14 Feb 2022 17:53:30 +0100 (CET) Received: from [IPv6:2001:67c:1220:80c:eb:e00e:9e81:ff5f] (unknown [IPv6:2001:67c:1220:80c:eb:e00e:9e81:ff5f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id D6EA3400074; Mon, 14 Feb 2022 17:53:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1644857609; bh=zQ+5pj5lehxL2Ndvnt7Zo6ZJtj3CmeT6MZ1MPhvulRk=; h=Subject:From:To:Date:In-Reply-To:References; b=epIU5MOFkmYCdHdlMFby/YkYYYx8xual9ZTzSAuOojxvWgKNICLe6wNiyIKep5Sye F3mOpx1H0LR1xeptyZ5v5STlH6gbrM+Lly6envKXH4v6SahBF/Zy8yrMJzEBytHkqp Dx4zmMjCDUvDvTrHkOUUbrp0ybqoMKAN5vyuB4s9WunFZN/kCazEn3gcTgk9jrfk+u VjCciMVUEJY0Xt3EKyuysAqv4CduScTedKvmm3cmwWwugr3/CHzDQ7LBDNTqb7EARh +P5ow7VnIem2dMpgde0cgg8GpRJI2aXQSVN0n4sqpF4lZNLIae7KjEY57Zwz31I1Ls iRv32/bmbYopw== Message-ID: <6f55f449b308cba7e5a512875fed58b7df745090.camel@cesnet.cz> Subject: Re: [PATCH 1/6] net/nfb: add missing libfdt dependency for build From: Martin Spinler To: Ferruh Yigit , dev@dpdk.org Date: Mon, 14 Feb 2022 17:53:29 +0100 In-Reply-To: References: <20220214112541.29782-1-spinler@cesnet.cz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 2022-02-14 at 13:36 +0000, Ferruh Yigit wrote: > On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote: > > From: Martin Spinler > > > > The driver uses some FDT manipulation functions from libfdt. > > Let the build system check for libfdt package. > > > > I don't see 'libfdt.h' included by the driver, where/how libfdt > is used? I've prepared this dependency for the future commit (fw_version_get feature), but i've omit it from this series for now due to internal discussion about versioning (can take a week or two) and doesn't realise that this 'libfdt' commit is now needless. The second fact is, it will not pass even in the current form without libfdt, because the netcope-common package (precisely the libnetcope headers included in DPDK driver) doesn't specify the libfdt-devel dependency. But this is a defect in the netcope-common package and should be fixed there. Anyway, I can remove this patch from series, but not sure if it will not confuse the Patchwork series/version matching as this is the first patch. Does it make sense to you to remove this patch from this series completely? > > Also what do you think to document this external dependency > and its usage in the driver documentation? > > > Signed-off-by: Martin Spinler > > --- > > drivers/net/nfb/meson.build | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build > > index bb5f66a09a..c080c06bf9 100644 > > --- a/drivers/net/nfb/meson.build > > +++ b/drivers/net/nfb/meson.build > > @@ -9,6 +9,12 @@ if is_windows > > subdir_done() > > endif > > > > +if has_libfdt == 0 > > + build = false > > + reason = 'missing dependency, "libfdt"' > > + subdir_done() > > +endif > > + > > dep = dependency('netcope-common', required: false, method: 'pkg-config') > > reason = 'missing dependency, "libnfb"' > > build = dep.found() >