DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nikolay Nikolaev <nicknickolaev@gmail.com>,
	anatoly.burakov@intel.com, tiwei.bie@intel.com,
	zhihong.wang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 5/5] vhost: message handling implemented as a callback array
Date: Wed, 26 Sep 2018 14:57:18 +0200	[thread overview]
Message-ID: <6f61cf0f-e8b1-bec9-d988-0e6d9632b40a@redhat.com> (raw)
In-Reply-To: <153782025279.27450.1954681982875165882.stgit@T460>

Hi Nikolay,

On 09/24/2018 10:17 PM, Nikolay Nikolaev wrote:
> +		switch (ret) {
> +		case VH_RESULT_ERR:
> +			RTE_LOG(ERR, VHOST_CONFIG,
> +				"Processing %s failed.\n",
> +				vhost_message_str[request]);
> +			break;
> +		case VH_RESULT_OK:
> +			RTE_LOG(DEBUG, VHOST_CONFIG,
> +				"Processing %s succeeded.\n",
> +				vhost_message_str[request]);
> +			break;
> +		case VH_RESULT_REPLY:
> +			RTE_LOG(INFO, VHOST_CONFIG,
I would prefer having it has DEBUG log level, do you agree?
If so, no need to resend for it, I can fixup while applying.

> +				"Processing %s succeeded and needs reply.\n",
> +				vhost_message_str[request]);
> +			send_vhost_reply(fd, &msg);
> +			break;
> +		}

Thanks,
Maxime

  reply	other threads:[~2018-09-26 12:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 20:16 [dpdk-dev] [PATCH v6 0/5] vhost: vhost_user.c code cleanup Nikolay Nikolaev
2018-09-24 20:17 ` [dpdk-dev] [PATCH v6 1/5] vhost: unify struct VhostUserMsg usage Nikolay Nikolaev
2018-09-25 15:43   ` Burakov, Anatoly
2018-09-24 20:17 ` [dpdk-dev] [PATCH v6 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-25 15:44   ` Burakov, Anatoly
2018-09-24 20:17 ` [dpdk-dev] [PATCH v6 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-25 15:44   ` Burakov, Anatoly
2018-09-24 20:17 ` [dpdk-dev] [PATCH v6 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-10-02  8:59   ` Maxime Coquelin
2018-10-05 21:34     ` Nikolay Nikolaev
2018-09-24 20:17 ` [dpdk-dev] [PATCH v6 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev
2018-09-26 12:57   ` Maxime Coquelin [this message]
2018-10-02  8:31   ` Maxime Coquelin
2018-09-26 13:51 ` [dpdk-dev] [PATCH v6 0/5] vhost: vhost_user.c code cleanup Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f61cf0f-e8b1-bec9-d988-0e6d9632b40a@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=nicknickolaev@gmail.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).