From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 4CE721B3BB
 for <dev@dpdk.org>; Wed, 26 Sep 2018 14:57:23 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com
 [10.5.11.25])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 96DFF3086249;
 Wed, 26 Sep 2018 12:57:22 +0000 (UTC)
Received: from [10.36.112.32] (ovpn-112-32.ams2.redhat.com [10.36.112.32])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id C81C62010D97;
 Wed, 26 Sep 2018 12:57:20 +0000 (UTC)
To: Nikolay Nikolaev <nicknickolaev@gmail.com>, anatoly.burakov@intel.com,
 tiwei.bie@intel.com, zhihong.wang@intel.com
Cc: dev@dpdk.org
References: <153782013094.27450.17651924330876922486.stgit@T460>
 <153782025279.27450.1954681982875165882.stgit@T460>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <6f61cf0f-e8b1-bec9-d988-0e6d9632b40a@redhat.com>
Date: Wed, 26 Sep 2018 14:57:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <153782025279.27450.1954681982875165882.stgit@T460>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.25
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.49]); Wed, 26 Sep 2018 12:57:22 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v6 5/5] vhost: message handling implemented
 as a callback array
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 12:57:23 -0000

Hi Nikolay,

On 09/24/2018 10:17 PM, Nikolay Nikolaev wrote:
> +		switch (ret) {
> +		case VH_RESULT_ERR:
> +			RTE_LOG(ERR, VHOST_CONFIG,
> +				"Processing %s failed.\n",
> +				vhost_message_str[request]);
> +			break;
> +		case VH_RESULT_OK:
> +			RTE_LOG(DEBUG, VHOST_CONFIG,
> +				"Processing %s succeeded.\n",
> +				vhost_message_str[request]);
> +			break;
> +		case VH_RESULT_REPLY:
> +			RTE_LOG(INFO, VHOST_CONFIG,
I would prefer having it has DEBUG log level, do you agree?
If so, no need to resend for it, I can fixup while applying.

> +				"Processing %s succeeded and needs reply.\n",
> +				vhost_message_str[request]);
> +			send_vhost_reply(fd, &msg);
> +			break;
> +		}

Thanks,
Maxime