From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DFEDA04AF; Fri, 18 Sep 2020 16:39:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CAB51D672; Fri, 18 Sep 2020 16:39:19 +0200 (CEST) Received: from dal3relay151.mxroute.com (dal3relay151.mxroute.com [64.40.27.151]) by dpdk.org (Postfix) with ESMTP id 51BE81D668 for ; Fri, 18 Sep 2020 16:39:17 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay151.mxroute.com (ZoneMTA) with ESMTPSA id 174a1a7a9180004d87.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 18 Sep 2020 14:39:13 +0000 X-Zone-Loop: deca99e41d178caa060e0e0a3425c6b943d844b6f19a X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 94DAC3ED9E; Fri, 18 Sep 2020 14:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SepiEqXFfGOacLFimk2ksT8rkigMt+ZZCWLXYIVTIbc=; b=EkO/DBvuAJtHIofiFc8Cb9SUtB HRei5GXlqgTFDV3UNA4GdSzA7Il/eY6wDZUZqfB3Mw5DNrLL3L4DTOtbZqgwo7dEJ2xh+MWDJ9ukd H+sOAr8ap0qI++IqjqkQRY0Zr1Lmk8032n/YVAJjANcQ3zqap7EY75UirLCUVBtsbYnZKVuBzv1Ix bgKKwOVrmVDIXtkTYfXPjUls+s4qS8/xewZKMFxz44x/1Uce0ao8BiFAPKEsLx5Z7gA0/MEIMzYG8 +f8/DHnKUYbvUvAjmvztyzgr2DXqPtjHM0fFz3NIulWBYnScyPoRR+2WKIDMWrACp1cUjAz71Vq4K QCiA/Awg==; To: Thomas Monjalon , dev@dpdk.org Cc: david.marchand@redhat.com, Andrew Rybchenko , John McNamara , Marko Kovacevic , Olivier Matz References: <20200914161801.572174-1-thomas@monjalon.net> <20200917104133.6186-1-thomas@monjalon.net> <20200917104133.6186-3-thomas@monjalon.net> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <6f705b05-6775-a87f-e599-96fc5b673401@ashroe.eu> Date: Fri, 18 Sep 2020 15:39:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200917104133.6186-3-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v2 2/4] mempool: remove physical address aliases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/09/2020 11:41, Thomas Monjalon wrote: > Remove the deprecated unioned fields physaddr and phys_addr > from the structures rte_mempool_objhdr and rte_mempool_memhdr. > They are replaced with the fields iova which are at the same offsets. > > Remove the deprecated macro MEMPOOL_F_NO_PHYS_CONTIG > which is an alias of the more recent MEMPOOL_F_NO_IOVA_CONTIG. > > Signed-off-by: Thomas Monjalon > Acked-by: Andrew Rybchenko > --- > doc/guides/rel_notes/release_20_11.rst | 6 ++++++ > lib/librte_mempool/rte_mempool.h | 13 ++----------- > 2 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index c49e612c43..71f970f1ac 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -88,6 +88,12 @@ API Changes > the structures ``rte_memseg`` and ``rte_memzone``. > The field ``iova`` is remaining from the old unions. > > +* mempool: Removed the unioned fields ``phys_addr`` and ``physaddr`` from > + the structures ``rte_mempool_memhdr`` and ``rte_mempool_objhdr``. > + The field ``iova`` is remaining from the old unions. > + The flag name ``MEMPOOL_F_NO_PHYS_CONTIG`` is removed, > + while the aliased flag ``MEMPOOL_F_NO_IOVA_CONTIG`` is kept. > + > * mbuf: Removed the unioned field ``refcnt_atomic`` from > the structures ``rte_mbuf`` and ``rte_mbuf_ext_shared_info``. > The field ``refcnt`` is remaining from the old unions. > diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h > index 6ad7e31170..9ea7ff934c 100644 > --- a/lib/librte_mempool/rte_mempool.h > +++ b/lib/librte_mempool/rte_mempool.h > @@ -138,11 +138,7 @@ struct rte_mempool_objsz { > struct rte_mempool_objhdr { > STAILQ_ENTRY(rte_mempool_objhdr) next; /**< Next in list. */ > struct rte_mempool *mp; /**< The mempool owning the object. */ > - RTE_STD_C11 > - union { > - rte_iova_t iova; /**< IO address of the object. */ > - phys_addr_t physaddr; /**< deprecated - Physical address of the object. */ > - }; > + rte_iova_t iova; /**< IO address of the object. */ > #ifdef RTE_LIBRTE_MEMPOOL_DEBUG > uint64_t cookie; /**< Debug cookie. */ > #endif > @@ -188,11 +184,7 @@ struct rte_mempool_memhdr { > STAILQ_ENTRY(rte_mempool_memhdr) next; /**< Next in list. */ > struct rte_mempool *mp; /**< The mempool owning the chunk */ > void *addr; /**< Virtual address of the chunk */ > - RTE_STD_C11 > - union { > - rte_iova_t iova; /**< IO address of the chunk */ > - phys_addr_t phys_addr; /**< Physical address of the chunk */ > - }; > + rte_iova_t iova; /**< IO address of the chunk */ > size_t len; /**< length of the chunk */ > rte_mempool_memchunk_free_cb_t *free_cb; /**< Free callback */ > void *opaque; /**< Argument passed to the free callback */ > @@ -269,7 +261,6 @@ struct rte_mempool { > #define MEMPOOL_F_SC_GET 0x0008 /**< Default get is "single-consumer".*/ > #define MEMPOOL_F_POOL_CREATED 0x0010 /**< Internal: pool is created. */ > #define MEMPOOL_F_NO_IOVA_CONTIG 0x0020 /**< Don't need IOVA contiguous objs. */ > -#define MEMPOOL_F_NO_PHYS_CONTIG MEMPOOL_F_NO_IOVA_CONTIG /* deprecated */ > > /** > * @internal When debug is enabled, store some statistics. > Acked-by: Ray Kinsella