From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2715E42580; Tue, 12 Sep 2023 20:30:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADF5C40293; Tue, 12 Sep 2023 20:30:06 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id A22B040289; Tue, 12 Sep 2023 20:30:04 +0200 (CEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38CIExoh024668; Tue, 12 Sep 2023 18:30:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=3Se6DD7osq2OVy0q9BtM0Q78KiuDoxcNJFHef9z4gTQ=; b=jJQ4pJ7FJnRNMuw3O7jIluL6uBjhgn2QPNMPQnIj5qEC8GwCvY92bcBy1rQGHpgxXCyL RW3CrXNxGf+BrH6Qf3fTFoiD20/Xd2I2dg93XneSnZV7eBBrB+8+aNyPsptf95PwL8Tj VaT026eriwzoq4XUNOhhE8UZQwFgacDQvSpOxBEihYxyQ7Ly0FfMB0p2Q09Nh2A8OYg6 AgfAcsSK3zR9PBUmihWST3pLiYAD0IMwnXpjb0nTLlhPsA2ES6iHLQtbla6P2v5qPEcs 58ExeQFnhH3sO4+v9DTn/1+VP7RAjBE/1oObM9k6SHJxtldXAGhAcV7xdQgTMyYEz8Y4 +w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3t2vq391nx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 18:30:03 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 38CIFPDl028118; Tue, 12 Sep 2023 18:30:03 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3t2vq391na-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 18:30:03 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 38CH1UaX012037; Tue, 12 Sep 2023 18:30:02 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3t13dynguf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 18:30:02 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 38CIU17831130152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 18:30:02 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BA84458067; Tue, 12 Sep 2023 18:30:01 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CC245805D; Tue, 12 Sep 2023 18:30:01 +0000 (GMT) Received: from [9.61.27.31] (unknown [9.61.27.31]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTPS; Tue, 12 Sep 2023 18:30:01 +0000 (GMT) Message-ID: <6f8647f1-778e-ce74-56db-72e5b129fae4@linux.vnet.ibm.com> Date: Tue, 12 Sep 2023 11:30:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 1/3] vhost: fix build for powerpc To: Bruce Richardson , dev@dpdk.org Cc: maxime.coquelin@redhat.com, stable@dpdk.org, Chenbo Xia , David Marchand References: <20230831121058.725577-1-bruce.richardson@intel.com> <20230831121058.725577-2-bruce.richardson@intel.com> Content-Language: en-US From: David Christensen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: PGxlrkShDw10kjE2LMaKauaOR6MTBOIG X-Proofpoint-ORIG-GUID: 30bkOr8SAjb9K9eUUBpp-34uet28sCi9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_17,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 malwarescore=0 bulkscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 mlxlogscore=595 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309120153 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/1/23 7:59 AM, Bruce Richardson wrote: > +PPC maintainer > > On Thu, Aug 31, 2023 at 01:10:56PM +0100, Bruce Richardson wrote: >> When building on Ubuntu using the packaged powerpc compiler[1], a >> warning is issued about the print format of the __u64 values. >> >> ../../lib/vhost/vduse.c: In function ‘vduse_vring_setup’: >> ../../lib/vhost/vhost.h:676:17: error: format ‘%llx’ expects argument of >> type ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka >> ‘long unsigned int’} [-Werror=format=] >> 676 | "VHOST_CONFIG: (%s) " fmt, prefix, ##args) >> | ^~~~~~~~~~~~~~~~~~~~~ >> >> Changing the format specifier to %lx, or to use PRIx64 breaks other >> builds, so the safest solution is to explicitly typecast the printed >> values to match the format string. >> >> [1] powerpc64le-linux-gnu-gcc (Ubuntu 12.3.0-1ubuntu1~23.04) 12.3.0 >> >> Fixes: a9120db8b98b ("vhost: add VDUSE device startup") >> Cc: maxime.coquelin@redhat.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Bruce Richardson >> --- Tested-by: David Christensen