* [dpdk-dev] [PATCH] net/sfc: fix VF error/missed stats mapping
@ 2019-01-16 9:43 Andrew Rybchenko
2019-01-16 19:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Rybchenko @ 2019-01-16 9:43 UTC (permalink / raw)
To: dev; +Cc: stable
VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed
packet because of overflow.
VADAPTER_RX_BAD_PACKETS accumulates a number of error conditions,
but mainly impossibility to deliver because of no descriptors
available, so it is better to classify it as imissed.
Fixes: 1caab2f1e684 ("net/sfc: add basic statistics")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 3886daf7a..9f59c8db9 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -537,8 +537,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
mac_stats[EFX_MAC_VADAPTER_TX_UNICAST_BYTES] +
mac_stats[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES] +
mac_stats[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES];
- stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_OVERFLOW];
- stats->ierrors = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS];
+ stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS];
stats->oerrors = mac_stats[EFX_MAC_VADAPTER_TX_BAD_PACKETS];
} else {
stats->ipackets = mac_stats[EFX_MAC_RX_PKTS];
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix VF error/missed stats mapping
2019-01-16 9:43 [dpdk-dev] [PATCH] net/sfc: fix VF error/missed stats mapping Andrew Rybchenko
@ 2019-01-16 19:45 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2019-01-16 19:45 UTC (permalink / raw)
To: Andrew Rybchenko, dev; +Cc: stable
On 1/16/2019 9:43 AM, Andrew Rybchenko wrote:
> VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed
> packet because of overflow.
>
> VADAPTER_RX_BAD_PACKETS accumulates a number of error conditions,
> but mainly impossibility to deliver because of no descriptors
> available, so it is better to classify it as imissed.
>
> Fixes: 1caab2f1e684 ("net/sfc: add basic statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-16 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-16 9:43 [dpdk-dev] [PATCH] net/sfc: fix VF error/missed stats mapping Andrew Rybchenko
2019-01-16 19:45 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).