From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D60231B84A for ; Mon, 9 Apr 2018 17:53:10 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7360A40201A1; Mon, 9 Apr 2018 15:53:10 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4763D111CB8C; Mon, 9 Apr 2018 15:53:09 +0000 (UTC) To: Fan Zhang , dev@dpdk.org Cc: jianjay.zhou@huawei.com, jianfeng.tan@intel.com, pawelx.wodkowski@intel.com References: <20180409153429.20123-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Message-ID: <6f996129-a45c-8f42-4d71-3e1bcea55656@redhat.com> Date: Mon, 9 Apr 2018 17:53:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180409153429.20123-1-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 09 Apr 2018 15:53:10 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 09 Apr 2018 15:53:10 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 15:53:11 -0000 Overall, please rename the commit title prefix to vhost/crypto. Thanks, Maxime On 04/09/2018 05:34 PM, Fan Zhang wrote: > Fixes: 256b132f41b2 ("vhost/crypto: add session message handler") > Fixes: 7b5ad7beee17 ("vhost/crypto: update makefile") > Fixes: 2ce5bd8c442d ("examples/vhost_crypto: add vhost crypto sample application") > > This patch fixes the bugs introduced in the above patches. > > Signed-off-by: Fan Zhang > --- > examples/vhost_crypto/main.c | 5 ----- > lib/librte_vhost/Makefile | 3 ++- > lib/librte_vhost/vhost_crypto.c | 8 ++++---- > 3 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index bc867240d..860200e29 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -95,11 +95,6 @@ parse_cryptodev_id(const char *q_arg) > > /* parse decimal string */ > pm = strtoul(q_arg, &end, 10); > - if ((pm == '\0') || (end == NULL) || (*end != '\0')) { > - RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg); > - return -1; > - } > - > if (pm > rte_cryptodev_count()) { > RTE_LOG(ERR, USER1, "Invalid Cryptodev ID %s\n", q_arg); > return -1; > diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile > index 2cc65f95e..92c267475 100644 > --- a/lib/librte_vhost/Makefile > +++ b/lib/librte_vhost/Makefile > @@ -18,7 +18,8 @@ LDLIBS += -lpthread > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y) > LDLIBS += -lnuma > endif > -LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net > +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net \ > + -lrte_cryptodev -lrte_hash > > # all source are stored in SRCS-y > SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \ > diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c > index d84513e7f..2acfc908c 100644 > --- a/lib/librte_vhost/vhost_crypto.c > +++ b/lib/librte_vhost/vhost_crypto.c > @@ -381,7 +381,7 @@ vhost_crypto_create_sess(struct vhost_crypto *vcrypto, > return; > } > > - VC_LOG_DBG("Session (key %lu, session %p) created.", > + VC_LOG_DBG("Session (key %llu, session %p) created.", > vcrypto->last_session_id, session); > > sess_param->session_id = vcrypto->last_session_id; > @@ -399,7 +399,7 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id) > (void **)&session); > > if (unlikely(ret < 0)) { > - VC_LOG_ERR("Failed to delete session (key %lu).", session_id); > + VC_LOG_ERR("Failed to delete session (key %llu).", session_id); > return -VIRTIO_CRYPTO_INVSESS; > } > > @@ -418,7 +418,7 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id) > return -VIRTIO_CRYPTO_ERR; > } > > - VC_LOG_DBG("Session (key %lu, session %p) deleted.", sess_id, > + VC_LOG_DBG("Session (key %llu, session %p) deleted.", sess_id, > session); > > return 0; > @@ -932,7 +932,7 @@ vhost_crypto_process_one_req(struct vhost_crypto *vcrypto, > &session_id, (void **)&session); > if (unlikely(err < 0)) { > err = VIRTIO_CRYPTO_ERR; > - VC_LOG_ERR("Failed to retrieve session id %lu", > + VC_LOG_ERR("Failed to retrieve session id %llu", > session_id); > goto error_exit; > } >