From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9425E14E8; Tue, 19 Jun 2018 11:21:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2018 02:21:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,242,1526367600"; d="scan'208";a="65345534" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.26.59]) ([10.252.26.59]) by fmsmga001.fm.intel.com with ESMTP; 19 Jun 2018 02:21:57 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: stable@dpdk.org References: <1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <6fb6125a-9f0a-4c37-a51b-c266f353d5b9@intel.com> Date: Tue, 19 Jun 2018 10:21:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1529351589-173939-1-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] memory: do not use base-virtaddr in secondary processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 09:22:00 -0000 On 18-Jun-18 8:53 PM, Dariusz Stojaczyk wrote: > Since secondary process' address space is highly dictated > by the primary process' mappings, it doesn't make much > sense to use base-virtaddr for secondary processes. > > This patch is intended to fix PCI resource mapping > in secondary processes using the same base-virtaddr > as their primary processes. PCI uses the end of the hugepage > memory area to map all resources. [pci_find_max_end_va()] > It works for primary processes, but can't be mapped 1:1 > by secondary ones, as the same addresses are currently always > occupied by shadow memseg lists, which were created with > eal_get_virtual_area(NULL, ...). > > ``` > PRIMARY PROCESS > 0x6e00e00000 388K rw-s- fbarray_memseg-2048k-1-3 > 0x6e01000000 16777216K r---- [ anon ] > 0x7201000000 16K rw-s- resource0 > > SECONDARY PROCESS > 0x6e00e00000 388K rw-s- fbarray_memseg-2048k-1-3 > 0x6e01000000 16777216K r---- [ anon ] > 0x7201000000 4K rw-s- fbarray_memseg-1048576k-0-0_203213 > ``` > > Fixes: 524e43c2ad9a ("mem: prepare memseg lists for multiprocess sync") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly