From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 297FF41CC1; Fri, 17 Feb 2023 16:03:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0245440EE3; Fri, 17 Feb 2023 16:03:24 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8008540EE1 for ; Fri, 17 Feb 2023 16:03:23 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AF3197D; Fri, 17 Feb 2023 18:03:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AF3197D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1676646202; bh=KKa9S3GZvJjhT3313Dt8r4pvOgyVj41H+Y81RdFtcMs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eY+gH3FG3yLhpsivZG/6XcUwqwu9aA+OHTzioefEMdQZlvwckqpkHDdxy1hgmYt9e gERNwrvj74ttUh28Aj1HELRhPrPZbbpkhdoJLh42QQr343AKHS9q2Mvj+/y41YAbh+ egQFozorJwVoKXDxnBEbiBfSUkaftwJexGLVZLz0= Message-ID: <6fc0cee5-9cce-90c0-e943-9a9d87706204@oktetlabs.ru> Date: Fri, 17 Feb 2023 18:03:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v6 1/2] ethdev: add Tx queue mapping of aggregated ports Content-Language: en-US To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ferruh.yigit@amd.com" , Aman Singh , Yuying Zhang Cc: "dev@dpdk.org" , Raslan Darawsheh References: <20230203050717.46914-1-jiaweiw@nvidia.com> <20230217105026.12927-1-jiaweiw@nvidia.com> <20230217105026.12927-2-jiaweiw@nvidia.com> <557ee985-b634-f630-0ef4-1b28f876f690@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/17/23 16:41, Jiawei(Jonny) Wang wrote: > Hi Andrew, > >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Friday, February 17, 2023 8:57 PM >> To: Jiawei(Jonny) Wang ; Slava Ovsiienko >> ; Ori Kam ; NBU-Contact- >> Thomas Monjalon (EXTERNAL) ; >> ferruh.yigit@amd.com; Aman Singh ; Yuying >> Zhang >> Cc: dev@dpdk.org; Raslan Darawsheh >> Subject: Re: [PATCH v6 1/2] ethdev: add Tx queue mapping of aggregated ports >> > [snip] >>> --- a/lib/ethdev/rte_ethdev.c >>> +++ b/lib/ethdev/rte_ethdev.c >>> @@ -6946,6 +6946,78 @@ >> rte_eth_buffer_split_get_supported_hdr_ptypes(uint16_t port_id, uint32_t >> *ptypes >>> return j; >>> } >>> >>> +int rte_eth_dev_count_aggr_ports(uint16_t port_id) { >>> + struct rte_eth_dev *dev; >>> + int ret; >>> + >>> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >>> + dev = &rte_eth_devices[port_id]; >>> + >>> + if (*dev->dev_ops->count_aggr_ports == NULL) >> >> Is it OK that tracing is long in this case? >> > > Do you mean that we don't need tracing in this case? Sorry for typo. I'm asking if it is OK that tracing is *lost* in this case. > >>> + return 0; >>> + ret = eth_err(port_id, (*dev->dev_ops->count_aggr_ports)(port_id)); >>> + >>> + rte_eth_trace_count_aggr_ports(port_id, ret); >>> + >>> + return ret; >>> +} >>> + >> >> [snip] >